Replace defunct caniuse jsonp.php?callback #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 13, 2018 19:21
…t the end (thx to string sort and not float sort)
|
Fixed the order of the version keys problem. |
|
Fairly done for now, would love to hear feedback from @patrickkettner Running our tests against the caniuse-db shows that only a few are wrong (unclear on which side):
Will open a seperate ticket for those. |
This reverts commit ddc7509.
This was referenced Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the integration tests try to use that callback function to get caniuse data and test the browser against it. Seems though that this API is gone for sometime already, openened an issue asking about it.
In the meantime I took the liberty to get the data directly from their github.
Noticed though that running the tests on Firefox they fail for quite some cases. Turns out the code thinks it has to test against the Firefox 3.6 (which obviously isnt correct).
This line:
Modernizr/test/browser/integration/caniuse.js
Line 315 in c2906e9
seems doesnt return the keys (via _keys()) in the original order so "3.6" is the last one in the retuned value and therefor gets taken in the _findLast call.
ANy advice on how to get the keys in the original order @patrickkettner ?