Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint #2304

Merged
merged 8 commits into from
May 3, 2018
Merged

Update eslint #2304

merged 8 commits into from
May 3, 2018

Conversation

rejas
Copy link
Member

@rejas rejas commented Mar 28, 2018

  • Updated eslint to latest version
  • Add eslint-plugin-jsdoc for jsDoc linting
  • Removed some old fragments from jshint and jscs still in the codebase.
  • Removed google preset from jscs, switching to new eslint google would result in > 800 errors so I didnt, maybe add a TODO / Issue for later?
  • Fixed warnings that arose from the update

@rejas rejas mentioned this pull request May 3, 2018
Closed
@patrickkettner patrickkettner merged commit c8595f0 into Modernizr:master May 3, 2018
@rejas rejas deleted the update_eslint branch May 4, 2018 06:07
rejas added a commit that referenced this pull request May 24, 2018
@rejas
Update eslint (#2304)
1956f0b 
* html5shiv files are excluded in grunt task already

* Fix some indendation errors

* Remove orphaned jshint files

* Use eslint-plugin-jsdoc for jsdoc

* Update eslint, remove incompatible google preset

* Update eslint-plugin-jsdoc, fix some new warnings
@rejas rejas added this to the Modernizr v3.7 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Modernizr v3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@rejas @patrickkettner