Repair detect regions #2091
Merged
Repair detect regions #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect regions is broken badly. It references an undefined property causing failure to run *any* detects. The cause is a missing dependency. Fixes this by including the missing dependency. Also updates the references to the free variable style, the correct pattern in the AMD module architecture. Fixes Modernizr#2079
|
Test of a build with this fix installed. The detect is executed and the outcome is displayed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect regions is broken badly. It invokes an undefined property
causing failure to run any detects. The cause is a missing
dependency.
Fixes this by including the missing dependency. Also updates the
references to the free variable style, the correct pattern
in the AMD module architecture.
Fixes #2079