Check for >=6 as chrome rounds down value when page is zoomed #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
@anthonycosgrave wanna help give this a test? |
|
@ryanseddon Thanks again for your help with this! I can confirm this fix works and there are no issues at any other zoom levels (50% to 200%) 👍 I've tested with: |
|
@patrickkettner seems the appveyor build just timed out happy can you kick it of again just to make sure. |
|
Any update? near future release for this issue? thanks !!! |
|
@patrickkettner can we cut a release |
|
yep. got a single change for webrtc datachannel (its throwing a hard error
in the version of edge that is about to be released.) will cut tonight after
…On Tue, Mar 14, 2017 at 9:00 PM, Ryan Seddon ***@***.***> wrote:
@patrickkettner <https://github.com/patrickkettner> can we cut a release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2005 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcaBqJR2GSgXHw6uFGqpBeh49CItyknks5rl2JsgaJpZM4IrO3g>
.
--
patrick
|
|
@patrickkettner can you please document the process too so I can avoid pinging you everytime |
|
with pleasure |
|
3.4.0 has been released, steps here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1935.
When zoomed >125% in chrome the injected div returns a rounded down height of 6.
Need help to make this is still returning correct results for other browsers.