fix nthchild false negative #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var elems = elem.getElementsByTagName('div'), | ||
| test = true; | ||
| var elems = elem.getElementsByTagName('div'), | ||
| correctWidths = true; |
There was a problem hiding this comment.
Can you change this to multiple var's this is an old one but all other tests should use this pattern going forward
|
done :) |
ryanseddon
added a commit
that referenced
this pull request
Nov 16, 2015
fix nthchild false negative
|
Thanks @mstrutt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a function in to
Modernizr.addTestresulted the code being executed afterelemhad been removed from the DOM (and so had no layout). I've moved the code to be executed immediately and the just the result (which I renamed just to make the last line a bit more human readable) passed intoModernizr.addTest.I searched the rest of the css feature-detects and nthchild appears to be the only test with this issue. That said, might be worth adding a little note to the docs about time of execution with
testStylesandaddTest.All tests passed locally before and after this fix, but it was a bit beyond me to dive into what's happening with them
fixes #1675