handful of updates for new site #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkettner
force-pushed
the
neue-updates
branch
from
6a2e330 to
0867460
Compare
patrickkettner
force-pushed
the
neue-updates
branch
from
0867460 to
67c7183
Compare
|
@ryanseddon could you give it a once over? |
| @@ -5,9 +5,22 @@ | |||
| var inBrowser = typeof define == 'function' && typeof define.amd == 'object'; | |||
| /* jshint -W117 */ | |||
|
|
|||
| var _extend = function(a, b) { | |||
There was a problem hiding this comment.
Could we not just use lodash.extend? We're using it already in a few places.
There was a problem hiding this comment.
its not loaded at this point in the browser context
|
LGTM 👍 |
patrickkettner
added a commit
that referenced
this pull request
Mar 24, 2015
handful of updates for new site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.