Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-detect: URL parser #1395

Merged
merged 1 commit into from
Jul 21, 2014
Merged

feature-detect: URL parser #1395

merged 1 commit into from
Jul 21, 2014

Conversation

jokeyrhyme
Copy link
Contributor

This is a feature detect for the built-in URL parser that Polymer relies on:

It's implemented in Chrome and Firefox, Safari does have the constructor but it doesn't return the expected object / prototype / etc.

@jokeyrhyme
Copy link
Contributor Author

Part of #1170

@patrickkettner
Copy link
Member

beautiful work, as always

patrickkettner added a commit that referenced this pull request Jul 21, 2014
@patrickkettner
Merge pull request #1395 from jokeyrhyme/urlparser
e0d9432 
feature-detect: URL parser
@patrickkettner patrickkettner merged commit e0d9432 into Modernizr:master Jul 21, 2014
@jokeyrhyme jokeyrhyme deleted the urlparser branch July 21, 2014 08:13
@jokeyrhyme
Copy link
Contributor Author

I try. :) <3

@SlexAxton
Copy link
Member

Get a room, guys.

patrickkettner added a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
@patrickkettner
Merge pull request Modernizr#1395 from jokeyrhyme/urlparser
55c718f 
feature-detect: URL parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jokeyrhyme @patrickkettner @SlexAxton