Add test for picture element support, per the proposed spec/impl. currently underway.
#1302
Conversation
| "name": "Relevant spec issue", | ||
| "href": "https://github.com/ResponsiveImagesCG/picture-element/issues/87" | ||
| }], | ||
| "warnings": ["Not yet implemented"] |
There was a problem hiding this comment.
you can nix this. I don't want to have to update it when it /is/ live, and its more for warnings about the actual detect, rather than support thereof
|
lgtm, other than the one nit |
|
Done and done. |
|
squish that b down to a single commit, then we will make can make you a world famous modernizr dev |
…urrently underway.
|
’Bout time I did something around here, really. |
|
amen to that |
Add test for `picture` element support, per the proposed spec/impl. currently underway.
|
Excellent stuff! |
| }] | ||
| } | ||
| !*/ | ||
| define(['Modernizr', 'createElement'], function( Modernizr ) { |
There was a problem hiding this comment.
You don't need this 'createElement' dep, AFAIK.
|
6edc017 |
|
shoulda caught it in the review, so I felt bad :] |
|
Another follow-up commit: f0666ff |
|
Hi, when will the |
|
Hey @verlok - after the v3 version goes live, which could be some time from now. In the mean time, rather than |
Add test for `picture` element support, per the proposed spec/impl. currently underway.
I understand if you guys want to hold off on merging this one until we see some real-world implementations, but wanted to sneak this over to you in advance—we made sure to add
window.HTMLPictureElementto the spec for the sake of easy testing. Happy to own any feature testing issues that should pop up when this thing starts landing in stable browsers, as well.