adds "noPrefixes" option, to opt-out vendor prefix check, fixes #1082 #1193
Conversation
|
quick nit - could you add "fixes #1082" to the description, so it closes it out if/when this is merged |
|
did it ;-) |
|
where? you reference the commit, but you don't use the string 'fixes #1082' in the PR or any commit message. also, could you squish everything down to a single commit for review? thanks dude! |
|
"fixes #1082" should be in the PR title ... I'll look into squishing, never did a rebase before! |
|
ah, it is. sorry about that. rebasing keeps the git history nice and clean, thanks for all the effort you've put in! |
|
boom, squished! |
adds "noPrefixes" option, to opt-out vendor prefix check, fixes #1082
|
Bravo, sir. Very exciting to see you land this. Cheers! |
|
Looking forward to a blog update on the subject :] |
| @@ -1,6 +1,6 @@ | |||
| define(['ModernizrProto'], function( ModernizrProto ) { | |||
| // List of property values to set for css tests. See ticket #21 | |||
| var prefixes = ' -webkit- -moz- -o- -ms- '.split(' '); | |||
| var prefixes = (ModernizrProto._config.usePrefixes ? ' -webkit- -moz- -o- -ms- '.split(' ') : []); | |||
There was a problem hiding this comment.
Why is this splitting with a function instead of using an array literal?
adds "noPrefixes" option, to opt-out vendor prefix check, fixes Modernizr#1082
Based upon #1082. By adding
noPrefixesto the config options, a flag is set to empty the vendor prefixes array used by testAllProps.Checkout #1082 (comment) for details.