-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for ES6 Promises #1169
Conversation
I don't really dig the repetition of of window.Promise, but thats not a big deal. could you add the polyfill to @jakearchibald's test that you linked to in the PR link? Also, I know that @paulirish had spoken with @stucox about adding a promise based syntax to the async tests. Are you guys cool with |
Sorry, I did not quite understand this, add what where? |
Sorry, upon rereading that that was really unclear. Could you add the ES6-Promises polyfill that you linked to to the polyfills.json and document it in this feature-detect |
Alright, sure thing. |
Ok, PR updated. Added "polyfills" and "caniuse" name. |
beautiful work, as always. 👍 from me, @stucox, you good with about the above API question? |
Add test for ES6 Promises
Sorry for the delay on weighing in on this. I can’t picture us using That said, my current thinking is that we’d just extend Modernizr.on('webp').then(function (result) {
// WebP supported
}, function (error) {
// WebP not supported
}); |
beauty, we were on the same train afterall. |
Add test for ES6 Promises
This feature test is from Jake Archibald's ES6 Promises polyfill.
Quick browser test:
Firefox 26 returns
false
Chrome 31.0.1650.63 returns
false
Chrome 34.0.1766.0 canary returns
true