fix firefox bug in videoautoplay, ensure check happens after a tick #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes my problem with Firefox - #1095 However, when I run the autoplay test I can sometimes see the video flash before the page is loaded. This can be fixed for example by setting visibility to hidden |
|
ah, that would be a great idea. I'll append it to this since it is a bit of a catchall bug. |
|
I can see the video flashing on Chrome too :) But at least this PR makes the test always return correct result on newest Chrome/FF. |
patrickkettner
added a commit
that referenced
this pull request
Dec 11, 2013
fix firefox bug in videoautoplay, ensure check happens after a tick
patrickkettner
added a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
fix firefox bug in videoautoplay, ensure check happens after a tick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1095
few things done here.
notessection (must have copied it from the animation test - thats embarrassing)playingevent when the time is === 0, so I added an optional argument that sets the test to true if it is called from theplayingevent listener.