added test for custom search event for input with type of search #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one. Bit of a nit pick, but could you indent the metadata JSON block ‘appropriately’? (see another detect for an example) |
formatting meta added test for custom search event for input with type of search
|
Thanks @stucox ! I've reformatted the metadata so its more readable. |
paulirish
added a commit
that referenced
this pull request
Nov 26, 2013
added test for custom search event for input with type of search
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
added test for custom search event for input with type of search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created test for the custom event
searchthat webkit browsers fire when entering anything on aninput[type=search]I tested it on
Safari
Chrome and Chrome Canary
Opera 12.16 and Opera 15 to see the test change since the webkit change
Firefox
Ie7 and ie9
This is definitely just a proposal to add this test, and am not sure of any browsers' (other than webkit) future implementation of the
searchevent.