Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Speech Synthesis test #1049

Merged
merged 1 commit into from
Sep 30, 2013
Merged

Web Speech Synthesis test #1049

merged 1 commit into from
Sep 30, 2013

Conversation

alrra
Copy link
Contributor

@alrra alrra commented Sep 28, 2013

Side note: AFAIK, only Safari for iOS 7 supports this feature.

@TalAter
Copy link
Contributor

TalAter commented Sep 29, 2013

@alrra Yes, I ran into it while researching Safari in iOS 7... I guess it's
the one thing they got right with the new iOS Safari.
I can't believe I let you beat me to modernizr again ;-)

P.S. Apparently Safari 7 for the Desktop should support
SpeechRecognition... could it be the first browser with full support of the
Web Speech API? Let's hope.

On Mon, Sep 30, 2013 at 1:06 AM, Cătălin Mariș notifications@github.comwrote:

@TalAter https://github.com/TalAter you may be interested in this. :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1049#issuecomment-25330336
.

!*/

define(['Modernizr', 'prefixed'], function (Modernizr, prefixed) {
Modernizr.addTest('speechsynthesis', !!prefixed('SpeechSynthesisUtterance', window));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is SpeechSynthesisUtterance prefixed in iOS7? Peter Gaston's article suggests not, and it isn't prefixed in Chrome Canary either, so maybe simply 'SpeechSynthesisUtterance' in window would do the job?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is SpeechSynthesisUtterance prefixed in iOS7 ?

No, it's not.

and it isn't prefixed in Chrome Canary either

AFAIK it's not supported in Chrome Canary yet (I'm using: Version 32.0.1655.0 canary on Mac OS X and Google Chrome is up to date). Am I missing something ? Is it behind a flag ?

so maybe simply 'SpeechSynthesisUtterance' in window would do the job?

For now, yes.

@stucox Do you want me to make the change ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's behind the "experimental Web Platform features" flag – with that enabled on my machine, window.SpeechSynthesisUtterance exists in 32.0.1655.0 canary (haven't actually tried using it…)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"experimental Web Platform features" flag

Ah ok, I missed that one. Thanks!

@stucox made the change. :)

@stucox
Copy link
Member

stucox commented Sep 30, 2013

Awesome, LGTM – thanks.

stucox pushed a commit that referenced this pull request Sep 30, 2013
@stucox stucox merged commit 230ee64 into Modernizr:master Sep 30, 2013
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants