-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android, indexedDB and .deleteDatabase method #979
Comments
So does Android not supporting this method render indexedDB useless? |
Nope; it's just not fully supported. The problem appears when you use Modernizr to check the indexedDB support; it just tells you a boolean answer. I think it should be handled somehow to let the user know about such missing part. |
Well, we have two options.
Based on the amount of questions on SO, code on github, and results on google, I would vote or option number 2. That being said, I could go either way since the addition would be pretty light weight. |
I’d be up for a subproperty here actually. |
What are you, me? :) On Sun, Feb 23, 2014 at 6:15 AM, Stu Cox notifications@github.com wrote:
|
Increasingly, yes. My name is Tyler Durden. |
Do you really feel that the actual test is relevant to many people? |
Well, to at least to @KingRial by the sounds of things. Are we going to start asking for use cases for every new detect we add? (genuine question/suggestion, not a dig – we’re pretty open in the feature requests we accept at the mo) |
As a matter of fact I really needed such test; discovering there were some Android with missing "deleteDatabase" method was an unexpected surprise and took some time to understand the situation and patch it. Recent Android mobiles don't have this problem anymore but, if you wish to support correctly the past, you need, at least, a warning in the documentation. A "subproperty" would be really nice to have if you are a lazy coder like me :D |
The only reason why I asked was because this only seems to affect some implementations of android that are broken, none of which are still shipping (from what I can tell). Its not so much a feature detect as it is checking for a lack of a broken implementation. |
Sounds more incomplete than broken? Especially if the |
ok - you convinced me. subproperty test is good. |
Just discovered that on some android browsers ( usually the native browser ) the indexedDB's "deleteDatabase" method is not supported.
See indexeddbshim/IndexedDBShim#37 for details.
Should be added a test case to handle such event.
The text was updated successfully, but these errors were encountered: