Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False Positive: Firefox shows IFrame sandbox capability though still broken #955

Closed
pannal opened this issue May 28, 2013 · 4 comments
Closed

False Positive: Firefox shows IFrame sandbox capability though still broken #955

pannal opened this issue May 28, 2013 · 4 comments

Comments

@pannal
Copy link

pannal commented May 28, 2013

Firefox's IFrame sandbox "support" doesn't actually sandbox since about 8 months:

https://bugzilla.mozilla.org/show_bug.cgi?id=785310

Not including "allow-top-navigation" into the sandbox attribute still allows the IFrame's Javascript to navigate the top window.
@patrickkettner
Copy link
Member

This was fixed in firefox 29, and given firefox's auto update, I think this can be closed out without action on our part. thoughts, @stucox ?

@stucox
Copy link
Member

stucox commented Mar 4, 2014

Hmm, won’t be in stable until May and can take a while to reach all users, but yeah I’m apprehensive about adding code for only a few months.

How would we go about blacklisting it? Is there a cleaner way than a UA sniff?

@patrickkettner
Copy link
Member

@stucox not from what I can tell. You can createElement('iframe') and set its src to a data:text,html script, and it throws and err, but it is not catchable from what I can tell. I would vote for this to be a note

@stucox
Copy link
Member

stucox commented Mar 13, 2014

+1

patrickkettner added a commit that referenced this issue Mar 16, 2014
@patrickkettner
Merge pull request #1266 from patrickkettner/oldffsandbox
7ea2b19 
add note about firefox broken sandbox support. fixes #955
patrickkettner added a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
@patrickkettner
add note about firefox broken sandbox support. fixes Modernizr#955
74a87c1
patrickkettner added a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
@patrickkettner
Merge pull request Modernizr#1266 from patrickkettner/oldffsandbox
5e5c983 
add note about firefox broken sandbox support. fixes Modernizr#955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patrickkettner @stucox @pannal