-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regions check returns false negative if page is zoomed (in/out) #940
Comments
Looks like a rounding funny, like we saw in #760... wrapping the delta calculation in a There might be a few places where we fall victim to this kind of thing tbh. |
stucox
pushed a commit
that referenced
this issue
May 25, 2013
Wrapping cssregions detect delta calculation in a parseInt fixes #940
SlexAxton
added a commit
to SlexAxton/Modernizr
that referenced
this issue
Jun 3, 2013
* 'master' of github.com:Modernizr/Modernizr: (23 commits) add opus detection - fixes Modernizr#699 Added note re. Chrome occassionally failing transforms3d detect updated/fixes Modernizr#696 - adds preload and loop checks for video and audio elements Wrapping cssregions detect delta calculation in a parseInt fixes Modernizr#940 Removed `touch` alias for `Modernizr.touchevents` - enough is enough fix for Modernizr#520 - check for chrome frame in download test update async warning rearrange test file structure, added warnings about test size Added a warning to `csshyphens` metadata re. its size Positioning #modernizr absolutely to enable more precise offsetLeft check whoops updating PR fixed another typo, added test/video as an AMD dependency check for video support first, only set src of the shortest supported video type, change body to docElement bail out of test early if autoplay isn't detected on the video element Fixed test for :checked pseudo-selector Update LICENSE optimize test arrangement, fix typo added escape hatch for browsers that don't support autoplay at all updates for @stucox ...
This was referenced Mar 2, 2014
Closed
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this issue
Feb 22, 2015
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this issue
Feb 22, 2015
Wrapping cssregions detect delta calculation in a parseInt fixes Modernizr#940
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this issue
Feb 22, 2015
* 'master' of github.com:Modernizr/Modernizr: (23 commits) add opus detection - fixes Modernizr#699 Added note re. Chrome occassionally failing transforms3d detect updated/fixes Modernizr#696 - adds preload and loop checks for video and audio elements Wrapping cssregions detect delta calculation in a parseInt fixes Modernizr#940 Removed `touch` alias for `Modernizr.touchevents` - enough is enough fix for Modernizr#520 - check for chrome frame in download test update async warning rearrange test file structure, added warnings about test size Added a warning to `csshyphens` metadata re. its size Positioning #modernizr absolutely to enable more precise offsetLeft check whoops updating PR fixed another typo, added test/video as an AMD dependency check for video support first, only set src of the shortest supported video type, change body to docElement bail out of test early if autoplay isn't detected on the video element Fixed test for :checked pseudo-selector Update LICENSE optimize test arrangement, fix typo added escape hatch for browsers that don't support autoplay at all updates for @stucox ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: