Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsmin.py UnterminatedRegularExpression in multiplebgs RegExp #78

Closed
rjcoelho opened this issue May 4, 2010 · 2 comments
Closed

jsmin.py UnterminatedRegularExpression in multiplebgs RegExp #78

rjcoelho opened this issue May 4, 2010 · 2 comments

Comments

@rjcoelho
Copy link

rjcoelho commented May 4, 2010

I know it's a jsmin bug but as a workaround please change:
return /(url\s_(.?){3}/.test(m_style[background]);
to:
return new RegExp("(url\s(._?){3}").test(m_style[background]);
@KuraFire
Copy link
Member

KuraFire commented May 4, 2010

Fixed in the 1.2 branch with this commit:

http://github.com/KuraFire/Modernizr-1.2-branch/commit/aba5610fff11a7b530706ef7bbed23f8e9a18c34

@paulirish
Copy link
Member

cc @gercheq

ref 7be8d4f#modernizr.js-P14

Hey Gercek.. this is a bug in jsmin.py to be honest. It isn't successfully parsing a completely valid regular expression. Right now I'm not spotting the home of jsmin.py so as far as I can tell it's abandoned. If not, I'm happy to report it upstream.

But we can't fix bugs for a minifier that can't parse valid javascript. :/ It's just not sustainable.

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
@KuraFire
Fix for an issue that triggers as a result of a jsmin bug in the mult…
ea9f5ea 
…iplebgs check.

Fixes Modernizr#78
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KuraFire @paulirish @rjcoelho