-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dir="rtl" causes display table test to fail #716
Comments
Can you create a test case please. |
I would suspect it's line 23 of css-display-table.js: |
The fiddle seems happy. |
Since I'm unfamiliar with the github flow for Modernizr, just checking: how to tell when this is available via modernizr.com? |
SlexAxton
added a commit
to SlexAxton/Modernizr
that referenced
this issue
Nov 5, 2012
* 'master' of github.com:Modernizr/Modernizr: (81 commits) use setAttribute before using deprecated setAttributeNode explicitly set height in scrollbar test fixes false positive in IE9 (Issue Modernizr#698) added page visibility API test Fix false negative of css table detect when document dir is rtl. Rewrote test. Fixes Modernizr#716 Update readme.md Remove BSD license and improve readme Added test for lossless WebP images Not by Addy Osmani binary websocket test likes to throw exceptions in Opera & Firefox and crash dolphin beta. nerfing for safety. navigator.cookieEnabled is a false pos in ie9. dont try it as a technique. thx @alrra. fixes Modernizr#666 bump 2.6.3pre on grunt bump to 2.6.3pre 2.6.2 When binding a function to a context, check that it actually has a bind method first. paul, you should always lint before you commit. sticky test. just formatting. whitespace. crlf's. fixing css-calc coding style, addTest gets no incoming arguments. ref Modernizr#673 Adds a test for position: (-webkit-)sticky support Make PhantomJS exit out of caniuse data matching early as it's unecessary ...
Closed
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this issue
Feb 22, 2015
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this issue
Feb 22, 2015
* 'master' of github.com:Modernizr/Modernizr: (81 commits) use setAttribute before using deprecated setAttributeNode explicitly set height in scrollbar test fixes false positive in IE9 (Issue Modernizr#698) added page visibility API test Fix false negative of css table detect when document dir is rtl. Rewrote test. Fixes Modernizr#716 Update readme.md Remove BSD license and improve readme Added test for lossless WebP images Not by Addy Osmani binary websocket test likes to throw exceptions in Opera & Firefox and crash dolphin beta. nerfing for safety. navigator.cookieEnabled is a false pos in ie9. dont try it as a technique. thx @alrra. fixes Modernizr#666 bump 2.6.3pre on grunt bump to 2.6.3pre 2.6.2 When binding a function to a context, check that it actually has a bind method first. paul, you should always lint before you commit. sticky test. just formatting. whitespace. crlf's. fixing css-calc coding style, addTest gets no incoming arguments. ref Modernizr#673 Adds a test for position: (-webkit-)sticky support Make PhantomJS exit out of caniuse data matching early as it's unecessary ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduced in:
(May happen in other browsers, this is what was handy)
The text was updated successfully, but these errors were encountered: