Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master #631

Merged
merged 1 commit into from
Jul 19, 2012
Merged

Update master #631

merged 1 commit into from
Jul 19, 2012

Conversation

urazkines
Copy link
Contributor

Better CSS first-child detect.

return elem.lastChild.offsetWidth > elem.firstChild.offsetWidth;
}, 1);
Modernizr.testStyles("#modernizr div {width:100px} #modernizr :last-child{width:200px;display:block}", function (elem) {
var lastchild = Modernizr.addTest('lastchild', elem.lastChild.offsetWidth > elem.firstChild.offsetWidth);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why assign to the var at all?

@ryanseddon
Copy link
Member

I think for consistency the addTest method should be the parent around any other method calls. Unless you do this for a reason?

@iboozyvoozy
Copy link

ios safari

@paulirish
Copy link
Member

pulling. and i'm going to fix this up after.

paulirish added a commit that referenced this pull request Jul 19, 2012
@paulirish paulirish merged commit 34df7a3 into Modernizr:master Jul 19, 2012
paulirish added a commit that referenced this pull request Jul 19, 2012
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants