Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include addTest by default #619

Closed
paulirish opened this issue Jun 20, 2012 · 3 comments
Closed

include addTest by default #619

paulirish opened this issue Jun 20, 2012 · 3 comments
Assignees
@SlexAxton
Milestone
Modernizr v2.6

Comments

@paulirish
Copy link
Member

see a lot of errors like http://stackoverflow.com/questions/11075507/modernizr-causes-errors-with-jquery-isotope reported in the wild.

and since we're moving to a 100% addtest api seems good to just say that method is core and required.
@SBoudrias
Copy link

+1 !!

@paulirish
Copy link
Member Author

@SlexAxton what changes need to happen at modulizr level to deal with this? I'd like to get this as part of 2.6 which shoudl ideally ship in the next week

@ghost ghost assigned SlexAxton Jun 20, 2012
@SlexAxton
Copy link
Member

We would just unwrap the addTest stuff. Modulizr can have unknown names and still work, as far as I know.

@drublic drublic mentioned this issue Jul 8, 2012
Closed
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
@paulirish
addTest should be included by default. fixes Modernizr#619
2a81ff6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SlexAxton SlexAxton

Labels
None yet
Projects
None yet
Milestone
Modernizr v2.6
Development

No branches or pull requests
3 participants
@paulirish @SlexAxton @SBoudrias