Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive - space and round Values for background-repeat #371

Closed
Banzai opened this issue Sep 10, 2011 · 2 comments
Closed

false positive - space and round Values for background-repeat #371

Banzai opened this issue Sep 10, 2011 · 2 comments

Comments

@Banzai
Copy link

Banzai commented Sep 10, 2011

on this site:
http://www.impressivewebs.com/demo-files/css3-space-round/

with this Browser - OS
Chrome 14.0.803.0 dev on Ubuntu 11.04

@ryanseddon
Copy link
Member

I think @paulirish and I were looking at a similar test and we found that testing the background-repeat property will false positive like you've discovered but if you check the background shorthand it returns the correct results based on browser support.

@ryanseddon
Copy link
Member

Found the test page http://jsfiddle.net/ryanseddon/yMLTQ/6/

SlexAxton added a commit to SlexAxton/Modernizr that referenced this issue Jul 12, 2012
* 'master' of github.com:Modernizr/Modernizr: (83 commits)
  who needs to feature detects cookies? who wants to just eat them instead?!
  test suite: duplicate ref to dumpdata.js .. whoops.
  test suite. minor. webgl may not be a pure boolean thx to recent plugin addition.
  webgl detect. there is a rumor of a FF version throwing on .getContext('webgl') Can't verify in FF4, but we sswitch order of contexts anyways.
  webgl-extensions detection. exposed like an object: Modernizr.webgl.OES_standard_derivatives
  Fixed false possitive in Chrome for round & space background-repeat values. Fixes Modernizr#371
  test suite. rel path because gh-pages doesnt have my repo stuff. better anyway. minor
  test suite. dont dump unit test items. but grab any async tests.
  test suite: automated feature-detects dumping via github api. omg.
  test suite. update jquery.
  test suite. little file reorg. no functional changes.
  minor. fixing urls that were mangled in 18463cb
  minor: remove scheme from URLs in the comments. more attractive.
  robust webgl detect returns as builds are custom now.
  chrome incognito doesnt throw on websqldb anymore. hooray.
  updated iOS private notes for localStorage. also a stronger test.
  make caniuse results play nice with our funky audio/video return types.
  lets include our plugin tests in the test suite.
  kill that nasty jquery global that gets created.
  version bump to 2.1pre.
  ...
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
* 'master' of github.com:Modernizr/Modernizr: (83 commits)
  who needs to feature detects cookies? who wants to just eat them instead?!
  test suite: duplicate ref to dumpdata.js .. whoops.
  test suite. minor. webgl may not be a pure boolean thx to recent plugin addition.
  webgl detect. there is a rumor of a FF version throwing on .getContext('webgl') Can't verify in FF4, but we sswitch order of contexts anyways.
  webgl-extensions detection. exposed like an object: Modernizr.webgl.OES_standard_derivatives
  Fixed false possitive in Chrome for round & space background-repeat values. Fixes Modernizr#371
  test suite. rel path because gh-pages doesnt have my repo stuff. better anyway. minor
  test suite. dont dump unit test items. but grab any async tests.
  test suite: automated feature-detects dumping via github api. omg.
  test suite. update jquery.
  test suite. little file reorg. no functional changes.
  minor. fixing urls that were mangled in 18463cb
  minor: remove scheme from URLs in the comments. more attractive.
  robust webgl detect returns as builds are custom now.
  chrome incognito doesnt throw on websqldb anymore. hooray.
  updated iOS private notes for localStorage. also a stronger test.
  make caniuse results play nice with our funky audio/video return types.
  lets include our plugin tests in the test suite.
  kill that nasty jquery global that gets created.
  version bump to 2.1pre.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants