binary websocket support #370

paulirish · 2011-09-08T22:50:34Z

window.WebSocket && (new WebSocket('ws://.')).binaryType

is the basic test.. truthy (returns "blob") if there is support.. as there is in new chrome canary.

https://plus.google.com/115535723976198353696/posts/ERN6zYozENV

The text was updated successfully, but these errors were encountered:

sirbarrence · 2013-01-30T21:48:59Z

In Modernizr 2.6.2, IE 10.0.9200.16438 on Win7

(new WebSocket('ws://.')).binaryType

throws

"Unspecified error."

so the test evals to false.

But if you supply a valid host instead of "."

(new WebSocket('ws://0.0.0.0')).binaryType

you get a truthy

"blob"

which causes the test eval to true. Of course you might later get some unsightly error on the console if the WebSocket doesn't get a response it expects. So I'm not really sure what should be used to test this if IE doesn't like ".".

ryanseddon · 2013-01-31T00:31:32Z

Also interesting to note if this is ran on an https page it will throw a security error in IE10 and Firefox but not Chrome.

ryanseddon · 2013-01-31T01:03:32Z

Ok so here's a potential solution that returns expected results. It looks like everyone but Chrome exposes binaryType on the WebSocket.prototype and since Chrome passes the original check no problems that's fine. But Opera doesn't expose binaryType and it will crack it if it's ran on a secure page. So I do a check for the protocol to switch between ws and wss. I do the in check first as that'll be cheaper and less error prone.

Modernizr.addTest('websocketsbinary', function() {
  var protocol = 'https:'==location.protocol?'wss':'ws',
      protoBin = "binaryType" in WebSocket.prototype;

  if("WebSocket" in window) {
      if( protoBin ) return protoBin;
      try {
          return !!(new WebSocket(protocol+'://.').binaryType);
      } catch (e){}
    }

    return false;
});

@sirbarrence can you try this test case and see if that returns expected results for you? http://codepen.io/ryanseddon/pen/Ggydu

ryanseddon · 2013-01-31T01:05:31Z

Actually i'll need to put that protoBin variable inside the if as non WebSocket browsers will throw. Updated test case.

sirbarrence · 2013-01-31T01:30:35Z

Yeah, seems ok. IE 8 & 9 are false and IE 10 is true as expected. Chrome 24 (Mac) and Firefox 18 (Mac) are true as expected.

* 'master' of github.com:Modernizr/Modernizr: (70 commits) Fixed a typo in `testMediaQuery()` Added wrapflow test, in AMD format - fixes Modernizr#786 Fixes missing brackets and removes unneeded "Pre 1.2" from the user agent regex ("webOS" already covers that). Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping Robustisize the binary WebSocket detect. Fixes Modernizr#370 Update detect for fullscreen api. Fixes Modernizr#739 Added DOM PointerEvents test as Modernizr.pointerevents Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...) Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though) Matches Modernizr#777 in v3 land. Matches Modernizr#774 in v3 land. Matches Modernizr#773 in v3 land. whitespace Adds 'peerconnection' feature detection, namespaces WebRTC features together Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (Modernizr#760) Added fileinput test mobile UA blacklist for issue Modernizr#772 Added fileinput test mobile UA blacklist for issue Modernizr#772 adding docs from alex's email. whitespace SUPERSECRET MICROSOFT REQUESTED SENSORSHIP ...

* 3pre: (58 commits) fill up metadata a bit more, a few new conventions Saving full dependecies into package.json Removing node_modules, adding in metadata reader, ignoring generated metadata remove the node modules via an ignore Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping Robustisize the binary WebSocket detect. Fixes Modernizr#370 Update detect for fullscreen api. Fixes Modernizr#739 Added DOM PointerEvents test as Modernizr.pointerevents Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...) Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though) Matches Modernizr#777 in v3 land. Matches Modernizr#774 in v3 land. Matches Modernizr#773 in v3 land. whitespace Adds 'peerconnection' feature detection, namespaces WebRTC features together Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (Modernizr#760) Added fileinput test mobile UA blacklist for issue Modernizr#772 Added fileinput test mobile UA blacklist for issue Modernizr#772 adding docs from alex's email. whitespace ... Conflicts: config-all.json feature-detects/css/animations.js feature-detects/forms/fileinput.js modular.html package.json

lotodore · 2013-12-23T21:18:55Z

Thanks for the fix - however, obviously this did not find its way into a stable release. This is still broken in 2.7.1. Could someone tell me please why this is not fixed in public release? If I generate code using
http://modernizr.com/download/#-websockets_binary
it is still broken.

patrickkettner · 2014-04-29T19:58:44Z

This was released in v2.8.0

@wrumsby

Detailed here: Modernizr/Modernizr#370 (comment) reported by @wrumsby: https://twitter.com/wrumsby/status/463808664688537603 cc @PaulKinlan

* 'master' of github.com:Modernizr/Modernizr: (70 commits) Fixed a typo in `testMediaQuery()` Added wrapflow test, in AMD format - fixes Modernizr#786 Fixes missing brackets and removes unneeded "Pre 1.2" from the user agent regex ("webOS" already covers that). Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping Robustisize the binary WebSocket detect. Fixes Modernizr#370 Update detect for fullscreen api. Fixes Modernizr#739 Added DOM PointerEvents test as Modernizr.pointerevents Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...) Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though) Matches Modernizr#777 in v3 land. Matches Modernizr#774 in v3 land. Matches Modernizr#773 in v3 land. whitespace Adds 'peerconnection' feature detection, namespaces WebRTC features together Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (Modernizr#760) Added fileinput test mobile UA blacklist for issue Modernizr#772 Added fileinput test mobile UA blacklist for issue Modernizr#772 adding docs from alex's email. whitespace SUPERSECRET MICROSOFT REQUESTED SENSORSHIP ...

* 3pre: (58 commits) fill up metadata a bit more, a few new conventions Saving full dependecies into package.json Removing node_modules, adding in metadata reader, ignoring generated metadata remove the node modules via an ignore Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping Robustisize the binary WebSocket detect. Fixes Modernizr#370 Update detect for fullscreen api. Fixes Modernizr#739 Added DOM PointerEvents test as Modernizr.pointerevents Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...) Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though) Matches Modernizr#777 in v3 land. Matches Modernizr#774 in v3 land. Matches Modernizr#773 in v3 land. whitespace Adds 'peerconnection' feature detection, namespaces WebRTC features together Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (Modernizr#760) Added fileinput test mobile UA blacklist for issue Modernizr#772 Added fileinput test mobile UA blacklist for issue Modernizr#772 adding docs from alex's email. whitespace ... Conflicts: config-all.json feature-detects/css/animations.js feature-detects/forms/fileinput.js modular.html package.json

A facke connection to 'wss://localhost:17523' (randomly chosen) to detect the WebSocket binary support is not the best solution. First of all, check of prototype has the property 'binaryType'. If not, perform a dummy connection to 'wss://.' instead of 'wss://localhost:17523'. This patch was inspired by the discussion and implementation of Modernizr: Modernizr/Modernizr#370 https://github.com/Modernizr/Modernizr/blob/master/feature-detects/websockets/binary.js

paulirish closed this as completed in 900ae15 Dec 5, 2011

ryanseddon reopened this Jan 31, 2013

ryanseddon closed this as completed in 19402ed Jan 31, 2013

SlexAxton pushed a commit to SlexAxton/Modernizr that referenced this issue Feb 14, 2013

Robustisize the binary WebSocket detect. Fixes Modernizr#370

7ffac48

tyssen mentioned this issue Jun 27, 2013

Binary websocket support and IE10 dmolsen/Detector#21

Open

dol mentioned this issue Mar 11, 2014

Improved websocket binary support detection novnc/noVNC#347

Merged

dcodeIO mentioned this issue Aug 11, 2014

Q: websockets binary safety & fallback in text mode protobufjs/protobuf.js#176

Closed

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

binary websocket detection. fixes Modernizr#370

1ac72d6

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Robustisize the binary WebSocket detect. Fixes Modernizr#370

598e9db

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Robustisize the binary WebSocket detect. Fixes Modernizr#370

6ac4b81

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

binary websocket support #370

binary websocket support #370

paulirish commented Sep 8, 2011

sirbarrence commented Jan 30, 2013

ryanseddon commented Jan 31, 2013

ryanseddon commented Jan 31, 2013

ryanseddon commented Jan 31, 2013

sirbarrence commented Jan 31, 2013

lotodore commented Dec 23, 2013

patrickkettner commented Apr 29, 2014

binary websocket support #370

binary websocket support #370

Comments

paulirish commented Sep 8, 2011

sirbarrence commented Jan 30, 2013

ryanseddon commented Jan 31, 2013

ryanseddon commented Jan 31, 2013

ryanseddon commented Jan 31, 2013

sirbarrence commented Jan 31, 2013

lotodore commented Dec 23, 2013

patrickkettner commented Apr 29, 2014