-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom modernizr builds crash IE8 #332
Comments
I have the same problem, if I use the uncompressed version I do not have this issue. I have ie8 to test on but not sure how to find whats causing the problem. |
Having the same issue with the following build in IE 8.0.6.001.18702/XP:
I have not yet tested with other builds. |
Update: also tested it with a full build using the generator:
Update: this is almost certainly related: scottjehl/Respond#27. I removed Modernizr from my page in order to test, and added HTML5 Shiv + Respond.js instead. WIth respond.js, the page throws this error in IE 8.0.6.001.18702/XP. Without, it's fine. Update 2: The issue definitely seems to be related to respond.js for me. Built the following:
...and it runs no problem in IE8/XP. Adding respond.js to the build throws the error. |
hmmmmm @scottjehl we got a problem it seems. |
Any progress on this? Wondering where I can get a Win XP version for testing this. :| |
Oops. oO The GUI mocked me. oO |
There is a comment with 8 bit bytes near the method tests['csstransforms3d'] that has what I'm guessing is a Microsoft "smart-quote" We experience crashes of IE8 when we do not set a charset when serving this file (like running under lighttpd) our fix: remove the comment |
@plockc you've built this version recently? can you give us the top of the file which has what tests are in the build? |
remove what comment? |
(sorry for all the edits, trying to figure out the code delimiters) I didn't see what looked like a list of tests (sorry, I'm helping the markup guys, I don't use the library myself), but here is the version:
Asking the markup guy that got it, it should be a full build, pulled from here: which I verify to have the same 8 bit bytes The comment is here:
the first line of the comment should have been "WebKit's" I assume Here is a test I use (found a high byte in jQuery 1.6.4.min with it as well):
Checking the latest from github, someone appears to be editing source code with a "smart quotes" editor and saving the file in UTF-8 (I think), there are many high byte sequences, for example hex E2 80 99 is a right single quote:
|
thank you so much for the detail @plockc |
I'am also having the issue of a 'crashing' IE8. The tab crashes and show indeed I'am using the minified version (from the html5 boilerplate) and can't find the comment in my modernizr source which is changed in the previous commit. Is this really all needed to fix this issue? To me it seems this won't help. |
@lode i would also get a minified version that does not include respond.js |
@paulirish but it seems to me that I do need respond.js. (Right now I've been able to "solve" it by using the development version of modernizr and minify it myself via jscompress.com. This one doesn't crash.) |
you dont need respond.js.. you can do mobile-first MQs and get IE support with a conditional comments and two css files. interesting bug though. :o |
Does this bug depend on shipping modernizr 2.1? Will it be fixed? Thanks guys! |
One data point for sufferers; We found that the attribute that triggered the IE crashes when combined with Modernizr was related to 'print' vs 'screen' style sheets 'media' attribute. We found that is you explicitly say 'screen' (which as you know is the default anyway) that leads to the IE crash. Here is the versions offending line:
We found if we avoid (3) we could avoid the IE crashes. We have not used @import but with do use @media, e.g. '@media only screen and (min-width: 480px)' Aaron. |
aaron fwiw this is a respond.js bug. |
and a fixed one at that! :) (but if you run into issues with it, please take the discussion over here: https://github.com/scottjehl/Respond/issues/ ) On Jan 31, 2012, at 9:27 AM, Paul Irish wrote:
|
Excellent Scott, glad this problem is fixed, but this problem was reported with 2.0.6 and I believe there hasn't been a release of Modernizr since the fix. So people using the current release version from http://www.modernizr.com/ (still 2.0.6 as of today) are still as far as I know getting the old version of Media Queries portion with this problem? |
I'm fairly certain the Modernizr team has pulled Respond.js out of their builder, so you'll have to include it manually from the Respond.js repo. You should find that this problem no longer exists I'm not sure exactly what the "media queries" checkbox does in there currently. Paul? On Feb 1, 2012, at 2:09 AM, whereisaaron wrote:
|
i thinkkkkkkkk it adds a Modernizr.mediaqueries = Modernizr.mq('only all'); to your file. I think. |
Oh okay - it's a support test. Right on. Thanks, Paul. On Feb 1, 2012, at 7:30 AM, Paul Irish wrote:
|
I'm getting the crash in IE 6/7/8 with a Modernizr 2.5.2 custom build (was not getting it with Modernizr 2.0.6). |
Respond.js is no longer included in Modernizr's builder, so I'm not sure of the problem you're encountering here. If it's a respond.js bug, please file it in the tracker over at https://github.com/scottjehl/Respond/issues Thanks! On Feb 8, 2012, at 11:07 PM, Donald Jenkins wrote:
|
I echo astorg's comment; just upgraded a site I've been working on to modernizr 2.5.2, and started getting hard crashes in IE 8. Went back to 2.0.6 and no crashes. I don't think respond.js is involved, as my custom build did not include it. Here is the custom build I was using in case it helps track down the problem: Modernizr 2.5.2 (Custom Build) | MIT & BSD |
I see the issue with IE 8 on Windows Server 2003 R2 SP2 (base OS is similar to XP) as well. Using the Modernizer 2.5.2 build without customizations (just html5shiv, load and the CSS classes without prefix). I don't use respond.js. I've created a little reproduction over here: agross/modernizr-bug-332@cad5b14 |
The custom Modernizer 2.5.2 build that ships with the latest version of the HTML5 Boilerplate is also causing complete browser shutdown crashes in IE8 on XP for me. Please for this as soon as possible, reverting to 2.0.6 now. After re-trying a couple of times, sometimes the browser doesn't crash but instead tries to re-load it a couple of times after failed attempts and eventually ends up at a url like res://ieframe.dll/acr_error.htm# *(domain, url). Also during the reloads it's showing a tooltip in the IE8 tab saying "This tab has been recovered". |
reopening. @aFarkas could you look at agross's testcase? |
Yeah, I will look into this issue. Just downloaded the testcase and I can reproduce the issue. Will work on this tomorrow :-) |
This seems very similar to http://bugs.jquery.com/ticket/9823 FWIW. |
Yeah, I'm pretty sure that this is the reason for this bug. Will look later into this and let you know. |
Same bug used to occur with Respond.js. This change fixed it. scottjehl/Respond@8016973 |
@dmethvin and @scottjehl Yes it turns out this was the bug. It came from html5shiv. Actually the fakeBody isn't really needed, because we tested wether a element with a hidden property is display: none. In fact all known browsers, which have implemented the hidden property also have implemented the corresponding style. So easy to fix + less code |
@scottjehl FYI: This is the fix used by jQuery - http://bugs.jquery.com/ticket/9823 @aFarkas The bug is still present in Modernizr (#501) due to a fake body being used in the tests, but looks like it can be fixed with the same fix the jQuery project used (worked for me). Thanks |
Are you sure about this? I saw the fakeBody in Modernizr, but I didn't touched the logic there, because it worked for me in my and in your testcase (no crash). Although, I was asking myself, wether I should be more paranoid and simply setting the background style for fakeBody as well. |
@aFarkas I don't think my testcase includes the html5shiv. Nor did jQuery 1.6.2. When I get home, I'll test again using the latest Modernizr from the repo and see if the problem remains. Thanks. |
This looks like a fix for my issue, but is there anyway to make a custom build of the dev version? (or when will this fix be released?) |
Modernizr 2.5.3 has now shipped including this fix. http://www.modernizr.com/download/ :) |
Hurrah!!!! Thanks Paul. |
Thanks everyone—it's solid now =] |
+1 With those thanks—here too custom 2.5.2 was crashing, custom 2.5.3 is rock solid. :) |
Thanks for fixing this guys! Just spent an afternoon wondering why IE 7 and 8 were constantly crashing on me... |
for me, a custom 2.5.3 is crashing ie 7.00.5730.13. any hints on how to debug? |
@tobsch Try different custom builds with different options selected to isolate which component is causing the crash. My guess is that it's the shiv or the print shiv b/c that caused the crash before. First try comparing a build with and without the shiv to see if it's the shiv. Also compare with a development build. Is the error you see the acr_error or something different? |
@tobsch |
If anyone still experiencing this issue is getting their custom builds from initializr, it's due to an outdated Respond script. The Respond folks fixed it with this commit (scottjehl/Respond@ed8479c5), but the initialzr modules using Respond still haven't pulled in these changes. Stay tuned to verekia/initializr#43. |
We have experienced that custom, compressed modernizr builds crash IE8,
resulting in showing this address in the addressbar:
res://ieframe.dll/acr_error.html/#
This is not happening in the compat modes of IE7 or IE8 in IE9.
Unfortunately we can't really test this any further as we don't have
a machine with IE8 installed. The machine we experienced this on,
was a Windows XP machine of one of our partner companies.
Using the uncompressed development version does work without errors:
http://www.modernizr.com/downloads/modernizr-2.0.6.js
The text was updated successfully, but these errors were encountered: