Addition to test for "rem" css3 value #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e property is ditched when it is applied to an element. Practically, the rem addresses the issue of compounding/inherited font-size definitions when using ems, instead, the rem is always tied to the font-size of 'html'/:root or 'medium' if the html element is sized in rems. http://www.w3.org/TR/css3-values/#relative0
|
see also the test at #253 |
|
zeitgeist alert! |
|
@nsfmc's FWIW, looks more Modernizr-like. |
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test for the
remcss3 value. the test checks to see if the property is ditched when it is used on an element's font-size.The
remaddresses the issue of compounding/inherited font-size definitions when using ems, instead, the rem is always tied to the font-size of 'html'/:root or 'medium' if the html element is sized in rems. It's described here:http://www.w3.org/TR/css3-values/#relative0
I woud normally have left this as an external test, but the addition to modernizr is so trivial that it seems like there's little reason not to test for it. Tested (successfully) on safari 5.05, firefox 3.5,3.6,4, opera 11.10, internet explorer 8,9.
The one thing that i'm not totally sold on is the test's name, rem lacks too much context (for now), so maybe fontsizerem or remsize or... i don't know. ideas? Also, i put it near the text-shadow test, but i'm sure it could go anywhere if these sorts of attributes are placed anywhere specific (i couldn't immediately tell).
hope it's useful,
--marcos