-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernizr Build Instructions are ambiguous #1910
Comments
|
Thanks, @SlexAxton! That's very helpful. What about the |
Not sure why that's going wrong. Maybe make sure you have a recent node.js version installed and that you successfully ran
|
that is how you create a build from the command line
it does run on windows (at least it does for me). You should be running it from the root of the repo, after running npm install. If you feel like you are able to make the directions clearer, please update the readme cheers! |
Here's what I'm seeing on my windows machine: Video which plays back quicker. |
isn't this #1714? |
Great find, @roblarsen. Thanks for pointing that out. I believe it is. |
thanks @roblarsen! lemme know if there is anything else, @zackhall |
@patrickkettner I think fixing this would be a good thing. You never know how many people don't even make it here. It's either documentation or something like this: https://github.com/roblarsen/Modernizr/blob/windows-command-line/bin/modernizr.bat Which just makes the errors go away on Windows (although I didn't thoroughly test it) |
Care to make a PR? |
@patrickkettner Yeah, I was planning to either way, I just wanted to put that option out there to see if it seemed okay before going through the time to test it. |
Passthrough script for Powershell and cmd.exe, fixes #1910
:D
|
The whole purpose of bower is to automagically download the dependency working/ready inst it? Now I'm being asked to cd into my bower dependencies Modernizr directory and issue a series of commands. Is there any possible way to include a pre-built ready version when using bower or is the modernizr file size becoming an issue? |
@tomshaw you're installing a builder, which is automagically downloaded and working. If you want to install a build you should use the zip functionality of our web builder:
|
Manually downloading a build is an option I do so with gsap and place it in my bower dependency folder. Another options is to manually check for the specific functionality by hand. Either way thanks for your help. |
I'm having difficulty with the build instructions for Modernizr in the README.
Generate everything in config-all.json
The first step is:
On Windows, running
./bin/modernizr -c lib/config-all.json
results in:To run tests (in Browswer)
Next issue is trying to run tests in the browser following:
serve
isn't recognized as a command. I dug into the Gruntfile.js and saw thebrowserTests
task, but that stops the server after the test completes. Is there a serve command similar to the one above that allows me to just refresh the browser window to re-run the tests?The text was updated successfully, but these errors were encountered: