-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build.js #1290
Update build.js #1290
Conversation
Is it necessary the ```cp.spawn``` calling in ``/lib/build.js`? Seems it can be simplified to ```cp.exec``` to be compatible in windows environment.
cc @doctyper – as the original author, is there any reason why we need to use |
Wait, |
What about this issue? |
According to the docs, Also, it appears |
Yes, you are right with it. I just thought that one really important thing is a callback calling after child is exit - looks like Anyway - any ideas how can I run this in Windows env? Thanks. |
Guys? =) It is still breaks on Windows... |
Ping @doctyper |
Unfortunately, I don't know the best way to get this working in Windows. I'm not quite sure it's even on the road map. I can tell you that at some point, we will switch build systems entirely and will move away from Grunt lock-in (see #1184). Once that lands, this issue will no longer exist. |
fixes Modernizr#1290 this gives us the least terrible of both worlds, using spawn unless windows, where we use exec. That way everyone can build
Using Patrick's commit from above (patrickkettner@c99e4c1), I was able to make gulp-modernizr work on Windows. @doctyper Is it true that «This would break the feedback flow in tools like grunt-modernizr» does not apply to gulp-modernizr or was I just lucky? |
@doctyper can correct me if I am wrong, but I took that to mean that it just makes it seem like grunt-modernizr isn't doing anything (since exec only outputs when completed). So on a slower machine, with a larger build, it would seem that it is just hanging for a long time. Therefore, |
fixes Modernizr#1290 this gives us the least terrible of both worlds, using spawn unless windows, where we use exec. That way everyone can build
fixes Modernizr#1290 this gives us the least terrible of both worlds, using spawn unless windows, where we use exec. That way everyone can build
big ups to @sindresorhus for pointing out win-spawn |
fixes Modernizr#1290 this gives us the least terrible of both worlds, using spawn unless windows, where we use exec. That way everyone can build
Is it necessary the
cp.spawn
calling in /lib/build.js? Seems it can be simplified tocp.exec
to be compatible in windows environment.