Adds UA blacklist to @font-face test as a stopgap.

This addresses the issue of false positives on WebOS, Android 2.0/2.1, and Windows Phone 7-7.8 while we consider a more robust feature test. Ref. #1120.
Modernizr · Dec 6, 2013 · 949d770 · 949d770 · timohanninen · Jan 16, 2014
1 parent ff40a84
commit 949d770
Showing 1 changed file with 32 additions and 9 deletions.
diff --git a/feature-detects/css/fontface.js b/feature-detects/css/fontface.js
@@ -2,7 +2,7 @@
 {
   "name": "@font-face",
   "property": "fontface",
-  "authors": ["Diego Perini"],
+  "authors": ["Diego Perini", "Mat Marquis"],
   "tags": ["css"],
   "knownBugs": [
     "False Positive: WebOS http://github.com/Modernizr/Modernizr/issues/342",
@@ -11,16 +11,39 @@
   "notes": [{
     "name": "@font-face detection routine by Diego Perini",
     "href": "http://javascript.nwbox.com/CSSSupport/"
+  },{
+    "name": "Filament Group @font-face compatibility research",
+    "href": "https://docs.google.com/presentation/d/1n4NyG4uPRjAA8zn_pSQ_Ket0RhcWC6QlZ6LMjKeECo0/edit#slide=id.p"
+  },{
+    "name": "Filament Grunticon/@font-face device testing results",
+    "href": "https://docs.google.com/spreadsheet/ccc?key=0Ag5_yGvxpINRdHFYeUJPNnZMWUZKR2ItMEpRTXZPdUE#gid=0"
+  },{
+    "name": "CSS fonts on Android",
+    "href": "http://stackoverflow.com/questions/3200069/css-fonts-on-android"
+  },{
+    "name": "@font-face and Android",
+    "href": "http://archivist.incutio.com/viewlist/css-discuss/115960"
   }]
 }
 !*/
 define(['Modernizr', 'testStyles'], function( Modernizr, testStyles ) {
-  testStyles('@font-face {font-family:"font";src:url("https://")}', function( node, rule ) {
-    var style = document.getElementById('smodernizr');
-    var sheet = style.sheet || style.styleSheet;
-    var cssText = sheet ? (sheet.cssRules && sheet.cssRules[0] ? sheet.cssRules[0].cssText : sheet.cssText || '') : '';
-    var bool = /src/i.test(cssText) && cssText.indexOf(rule.split(' ')[0]) === 0;
-
-    Modernizr.addTest('fontface', bool);
-  });
+    var blacklist = (function() {
+      var ua = navigator.userAgent;
+      var wkvers = ua.match( /applewebkit\/([0-9]+)/gi ) && parseFloat( RegExp.$1 );
+      var webos = ua.match( /w(eb)?osbrowser/gi );
+      var wppre8 = ua.match( /windows phone/gi ) && ua.match( /iemobile\/([0-9])+/gi ) && parseFloat( RegExp.$1 ) >= 9;
+      var oldandroid = wkvers < 533 && ua.match( /android/gi );
+      return webos || oldandroid || wppre8;
+    }());
+    if( blacklist ) {
+      Modernizr.addTest('fontface', false);
+    } else {
+      testStyles('@font-face {font-family:"font";src:url("https://")}', function( node, rule ) {
+        var style = document.getElementById('smodernizr');
+        var sheet = style.sheet || style.styleSheet;
+        var cssText = sheet ? (sheet.cssRules && sheet.cssRules[0] ? sheet.cssRules[0].cssText : sheet.cssText || '') : '';
+        var bool = /src/i.test(cssText) && cssText.indexOf(rule.split(' ')[0]) === 0;
+        Modernizr.addTest('fontface', bool);
+      });
+    }
 });