Skip to content

Commit

Permalink
A clean up of some recent activity regarding dependencies. See #1159
Browse files Browse the repository at this point in the history
These dependencies are only used for testing. They should be moved to devDependencies.

The benefits for this include a faster install time, and suppressing the `>> Local Npm module "grunt-contrib-qunit" not found` errors references in Issue #1154

Removing qunit from the default task, since it is now a conditional dev dependency.
  • Loading branch information
doctyper committed Dec 11, 2013
1 parent 06089bc commit 2330848
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ module.exports = function( grunt ) {
});

// Load required contrib packages
require('matchdep').filterAll(['grunt-*', '!grunt-cli']).forEach(grunt.loadNpmTasks);
require('matchdep').filter(['grunt-*', '!grunt-cli']).forEach(grunt.loadNpmTasks);

// devDependencies may or may not be installed
require('matchdep').filterDev('grunt-*').forEach(function (contrib) {
Expand Down Expand Up @@ -258,5 +258,5 @@ module.exports = function( grunt ) {

// Build
grunt.registerTask('build', ['clean', 'generateinit', 'requirejs', 'copy', 'clean:postbuild', 'stripdefine', 'uglify']);
grunt.registerTask('default', ['build', 'jshint', 'qunit']);
grunt.registerTask('default', ['build', 'jshint']);
};
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
"grunt-contrib-clean": "~0.4.0",
"grunt-contrib-copy": "~0.4.0",
"grunt-contrib-requirejs": "~0.4.0",
"grunt-contrib-connect": "~0.5.0",
"grunt-saucelabs": "~4.0.4",
"grunt-cli": "~0.1.11"
},
"devDependencies": {
"grunt-contrib-connect": "~0.5.0",
"grunt-saucelabs": "~4.0.4",
"grunt-contrib-qunit": "~0.2.0",
"grunt-contrib-nodeunit": "~0.2.0"
},
Expand Down

0 comments on commit 2330848

Please sign in to comment.