update filter check to use CSS.supports when supported, gets around f…

…alse negatives in firefox
Modernizr · Mar 4, 2015 · 0c35733 · 0c35733
1 parent fff77ca
commit 0c35733
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/feature-detects/css/filters.js b/feature-detects/css/filters.js
@@ -12,13 +12,22 @@
   }]
 }
 !*/
-define(['Modernizr', 'createElement', 'prefixes'], function( Modernizr, createElement, prefixes ) {
+define(['Modernizr', 'createElement', 'prefixes', 'test/css/supports'], function( Modernizr, createElement, prefixes ) {
   // https://github.com/Modernizr/Modernizr/issues/615
   // documentMode is needed for false positives in oldIE, please see issue above
   Modernizr.addTest('cssfilters', function() {
     var el = createElement('div');
     el.style.cssText = prefixes.join('filter:blur(2px); ');
-    return !!el.style.length && ((document.documentMode === undefined || document.documentMode > 9));
+    if (Modernizr.supports) {
+      var supports = 'CSS' in window ?
+        window.CSS.supports('filter', 'url()') :
+        window.supportsCSS('filter', 'url()');
+
+      // older firefox only supports `url` filters;
+      return supports;
+    } else {
+      return !!el.style.length && ((document.documentMode === undefined || document.documentMode > 9));
+    }
   });
 
 });
diff --git a/test/browser/integration/caniuse.js b/test/browser/integration/caniuse.js
@@ -205,6 +205,11 @@ window.caniusecb = function(caniuse) {
         });
       }
 
+      // caniuse counts `filter` opacity as partial support - we don't.
+      if (o.feature === 'opacity' && o.browser === 'IE' && o.version < 9) {
+        return;
+      }
+
       // if caniuse gave us a 'partial', lets let it pass with a note.
       if (o.caniuseResult.indexOf('a') === 0) {
         return it(o.browser + o.version + ': Caniuse reported partial support for ' + o.ciufeature, function() {
@@ -213,11 +218,6 @@ window.caniusecb = function(caniuse) {
         });
       }
 
-      // caniuse counts `filter` opacity as partial support - we don't.
-      if (o.feature === 'opacity' && o.browser === 'IE' && o.version < 9) {
-        return;
-      }
-
       // where we actually do most our assertions
       it(o.browser + o.version + ': Caniuse result for ' + o.ciufeature + ' matches Modernizr\'s ' + (o.fp ? '*false positive*' : 'result') + ' for ' + o.feature, function() {
         var modernizrResult = o.result instanceof Boolean ? o.result.valueOf() : !!o.result;