[DOP-22127] Implement FileModifiedTime filter #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
c874d46 to
8433597
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #330 +/- ##
===========================================
+ Coverage 91.84% 91.86% +0.02%
===========================================
Files 227 228 +1
Lines 9790 9840 +50
Branches 999 1007 +8
===========================================
+ Hits 8992 9040 +48
- Misses 606 607 +1
- Partials 192 193 +1 ☔ View full report in Codecov by Sentry. |
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
8433597 to
520524d
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
520524d to
cf6f19c
Compare
dolfinus
changed the title
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
cf6f19c to
053974d
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
053974d to
a5dd206
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
a5dd206 to
e38b065
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
e38b065 to
abfd071
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
abfd071 to
b628f99
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
b628f99 to
dc054f9
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
dc054f9 to
aea769c
Compare
dolfinus
force-pushed
the
feature/DOP-22127
branch
from
aea769c to
e983a57
Compare
IlyasDevelopment
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Implemented
FileModifiedTime(since=..., until=...)file filter.Also improved integration tests for
FileDownloader(filters=[...])andFileUploader(filters=[...])- list of exact filenames is compared when possible, added integration tests for Regexp and FileSizeRange.I've discovered that
.walk(dir)or.listdir(dir)methods in most of connectors (excluding FTP/FTPS) return timestamp which is rounded to the whole second, but.get_stat(file)method may return timestamp with milliseconds or microseconds precision. Added a note to filter documentation.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)