Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-22128] Implement FileModifiedTimeHWM #109

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[DOP-22128] Implement FileModifiedTimeHWM #109

merged 1 commit into from
Jan 27, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 24, 2025 •
edited
Loading

Change Summary

Implement FileModifiedTimeHWM. It tracks file modification time (pathlib.Path.stat().st_mtime) and stores value as tz-aware datetime.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jan 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.37%. Comparing base (b5e5dba) to head (6e3cbb9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
etl_entities/hwm/file/file_mtime_hwm.py 88.88% 2 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
- Coverage    92.53%   92.37%   -0.16%     
===========================================
  Files           50       51       +1     
  Lines         1232     1285      +53     
  Branches       129      139      +10     
===========================================
+ Hits          1140     1187      +47     
- Misses          76       78       +2     
- Partials        16       20       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review January 27, 2025 09:10
@dolfinus dolfinus marked this pull request as draft January 27, 2025 09:16
@dolfinus dolfinus marked this pull request as ready for review January 27, 2025 09:23
@dolfinus dolfinus merged commit 39a40e5 into develop Jan 27, 2025
13 of 14 checks passed
@dolfinus dolfinus deleted the feature/DOP-22128 branch January 27, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyasDevelopment IlyasDevelopment IlyasDevelopment approved these changes

@TiGrib TiGrib Awaiting requested review from TiGrib

Assignees

@dolfinus dolfinus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolfinus @IlyasDevelopment