Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to list only windows from front application #8

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Option to list only windows from front application #8

merged 2 commits into from
Mar 23, 2024

Conversation

wti
Copy link
Contributor

@wti wti commented Feb 19, 2024

PR:

  • Creates a Bool preference to restrict windows listed to the frontmost app
  • Adds a Bool parameter to the menu-updating code listing windows
  • Updates the existing window-listing filter to implement the preference/parameter

Manually tested on macOS 14.

Note filtering now assumes an owning application and non-empty title in all cases.

Mnpn
Mnpn reviewed Feb 27, 2024
View reviewed changes
Copy link
Owner

@Mnpn Mnpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm curious about what made you add this, do you frequently have a lot of windows open, and/or rarely want to record things from apps not in focus? (That would make sense, now that I think about it :-) )

Azayaka/Preferences.swift Outdated Show resolved Hide resolved
Mnpn
Mnpn approved these changes Mar 23, 2024
View reviewed changes
Copy link
Owner

@Mnpn Mnpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR! (and apologies for my response taking so long)

@Mnpn Mnpn merged commit 67e4178 into Mnpn:main Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnpn Mnpn Mnpn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wti @Mnpn