Fix upscale script checking #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Hires fix is enabled, controlnet inpu image will always be cropped since Hires fix's script name is
Hires Upscale(r).This causes issues with some extensions like ADetailer.
One case is when using IP-Adapter FaceID with ADetailer, the input face image will be cropped, and Insightface will fail to detect faces in the cropped image.
This pull request fixes this issue.
For future improvement, I suggest that a new argument (e.g.
is_cropping_disabledwith default valueFalse) should be added to allow third-party extension to disable this cropping feature.