Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arguments and options of WinGet commands #4526

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

mdanish-kh
Copy link
Contributor

Added new arguments / options that are supported on the latest 1.5 stable release of WinGet.

Here is a summary of the changes:

  • Changed order of commands to match as they appear in the WinGet client to make this easy to review if you see the corresponding WinGet client outputs
  • Added new options / modified existing ones to be up to date with the WinGet client
  • -?, --help is classified as an option not an argument in most commands, so I have changed that accordingly in the docs
  • Trimmed trailing whitespaces from the markdown files
  • Add arguments and options for each subcommand of winget source to be consistent with how they are listed in other commands, say winget pin

@prmerger-automator
Copy link
Contributor

@mdanish-kh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit f919c10:

⚠️ Validation status: warnings

File Status Preview URL Details
hub/package-manager/winget/upgrade.md ⚠️Warning Details
hub/package-manager/winget/export.md ✅Succeeded
hub/package-manager/winget/hash.md ✅Succeeded
hub/package-manager/winget/import.md ✅Succeeded
hub/package-manager/winget/install.md ✅Succeeded
hub/package-manager/winget/list.md ✅Succeeded
hub/package-manager/winget/pinning.md ✅Succeeded
hub/package-manager/winget/search.md ✅Succeeded
hub/package-manager/winget/show.md ✅Succeeded
hub/package-manager/winget/source.md ✅Succeeded
hub/package-manager/winget/uninstall.md ✅Succeeded
hub/package-manager/winget/validate.md ✅Succeeded

hub/package-manager/winget/upgrade.md

  • Line 97, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'Animation demonstrating upgrade command' is duplicated. Within an article, alt text must be unique.
  • Line 103, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'Animation demonstrating upgrade command' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 77175b4:

✅ Validation status: passed

File Status Preview URL Details
hub/package-manager/winget/export.md ✅Succeeded
hub/package-manager/winget/hash.md ✅Succeeded
hub/package-manager/winget/import.md ✅Succeeded
hub/package-manager/winget/install.md ✅Succeeded
hub/package-manager/winget/list.md ✅Succeeded
hub/package-manager/winget/pinning.md ✅Succeeded
hub/package-manager/winget/search.md ✅Succeeded
hub/package-manager/winget/show.md ✅Succeeded
hub/package-manager/winget/source.md ✅Succeeded
hub/package-manager/winget/uninstall.md ✅Succeeded
hub/package-manager/winget/upgrade.md ✅Succeeded
hub/package-manager/winget/validate.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7553683:

⚠️ Validation status: warnings

File Status Preview URL Details
hub/app-resources/images-tailored-for-scale-theme-contrast.md ⚠️Warning Details
hub/apps/windows-app-sdk/mrtcore/images-tailored-for-scale-theme-contrast.md ⚠️Warning Details
hub/package-manager/winget/export.md ✅Succeeded
hub/package-manager/winget/hash.md ✅Succeeded
hub/package-manager/winget/import.md ✅Succeeded
hub/package-manager/winget/install.md ✅Succeeded
hub/package-manager/winget/list.md ✅Succeeded
hub/package-manager/winget/pinning.md ✅Succeeded
hub/package-manager/winget/search.md ✅Succeeded
hub/package-manager/winget/show.md ✅Succeeded
hub/package-manager/winget/source.md ✅Succeeded
hub/package-manager/winget/uninstall.md ✅Succeeded
hub/package-manager/winget/upgrade.md ✅Succeeded
hub/package-manager/winget/validate.md ✅Succeeded

hub/app-resources/images-tailored-for-scale-theme-contrast.md

  • Line 10, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Load images and assets tailored for scale, theme, high contrast, and others' is duplicated with other articles: 'app-resources/images-tailored-for-scale-theme-contrast.md(10,1), apps/windows-app-sdk/mrtcore/images-tailored-for-scale-theme-contrast.md(11,1)'. First level headings must be unique within a docset.

hub/apps/windows-app-sdk/mrtcore/images-tailored-for-scale-theme-contrast.md

  • Line 11, Column 1: [Warning: duplicate-h1s - See documentation] H1 'Load images and assets tailored for scale, theme, high contrast, and others' is duplicated with other articles: 'app-resources/images-tailored-for-scale-theme-contrast.md(10,1), apps/windows-app-sdk/mrtcore/images-tailored-for-scale-theme-contrast.md(11,1)'. First level headings must be unique within a docset.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mattwojo
Copy link
Contributor

Looks good -- thank you for making these contributions to improve the docs @mdanish-kh!

@mattwojo mattwojo merged commit c8a4409 into MicrosoftDocs:docs Jul 28, 2023
@mdanish-kh mdanish-kh deleted the fixArgsAndOptions branch July 28, 2023 20:18
learn-build-service-prod bot added a commit that referenced this pull request Jul 2, 2024
…c_temp

For protected branch, push strategy should use PR and merge to target branch method to work around git push error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants