Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powertoys Run ValueGenerator docs #4509

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Powertoys Run ValueGenerator docs #4509

merged 3 commits into from
Aug 1, 2023

Conversation

IHorvalds
Copy link
Contributor

This PR is in reference to microsoft/PowerToys#26097.

@prmerger-automator prmerger-automator bot requested a review from mattwojo June 27, 2023 07:46
@prmerger-automator
Copy link
Contributor

@IHorvalds : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c1fbff9:

✅ Validation status: passed

File Status Preview URL Details
hub/powertoys/run.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@IHorvalds IHorvalds mentioned this pull request Jun 27, 2023
Merged
11 tasks
@IHorvalds IHorvalds marked this pull request as ready for review June 27, 2023 12:49
@alvinashcraft alvinashcraft self-requested a review June 29, 2023 13:38
alvinashcraft
alvinashcraft approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@alvinashcraft alvinashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving to publish with the 0.72.0 release.

@alvinashcraft alvinashcraft merged commit 097ea13 into MicrosoftDocs:docs Aug 1, 2023
@IHorvalds
Copy link
Contributor Author

Thank you! :)

@IHorvalds
Copy link
Contributor Author

@alvinashcraft Hey, it seems I made a mistake in the formatting in this section:
https://learn.microsoft.com/en-us/windows/powertoys/run#value-generator-plugin

image

@alvinashcraft
Copy link
Contributor

@IHorvalds Good catch. I can go try to fix it up quickly.

@IHorvalds
Copy link
Contributor Author

It looks right in the GitHub preview:
https://github.com/MicrosoftDocs/windows-dev-docs/blob/docs/hub/powertoys/run.md
image

@alvinashcraft
Copy link
Contributor

It looks fine in my VS Code preview pane too. I'm going to try adding a line break after "Examples:" and push to my branch. I can preview on the internal docs site with the windows-dev-docs-pr repo.

@alvinashcraft
Copy link
Contributor

It looks good on the review site in my branch after adding some line breaks. I'll get a PR merged ASAP.

@IHorvalds
Copy link
Contributor Author

That's awesome! Thank you!

@alvinashcraft
Copy link
Contributor

You're welcome. The table should be rendering on the live site now. 😊

learn-build-service-prod bot added a commit that referenced this pull request Jun 29, 2024
@learn-build-service-prod
Merge pull request #4509 from MicrosoftDocs/main638552175623096822syn…
d091aab 
…c_temp

For protected branch, push strategy should use PR and merge to target branch method to work around git push error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvinashcraft alvinashcraft alvinashcraft approved these changes

@mattwojo mattwojo Awaiting requested review from mattwojo

Assignees

@alvinashcraft alvinashcraft

Labels
Change sent to author dev-environment/prod do-not-merge powertoys/tech PowerToys docs qualifies-for-auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IHorvalds @alvinashcraft @mattwojo