Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for CA1716 to mention configurability of symbol kinds #5009

Merged
merged 4 commits into from
Apr 17, 2020

Conversation

Evangelink
Copy link
Contributor

Fix #4982

This new feature is not yet publicly released. Please sync-up with @mavasani for when to merge this PR.

@PRMerger20
Copy link
Contributor

@Evangelink : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@@ -52,10 +52,20 @@ You can suppress a warning from this rule if you're convinced that the identifie

## Configurability

### Analyzed types and members surface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent with the heading: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1802?view=vs-2019#api-surface

Suggested change
### Analyzed types and members surface
### Api Surface

Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one suggestion to update the heading for consistency.

We have released 3.0.0-beta3, and will soon release 3.0.0 for the package. I think it is fine to publish this documentation.

If you're running this rule from [FxCop analyzers](install-fxcop-analyzers.md) (and not with legacy analysis), you can configure which parts of your codebase to run this rule on, based on their accessibility. For example, to specify that the rule should run only against the non-public API surface, add the following key-value pair to an .editorconfig file in your project:

```ini
dotnet_code_quality.ca1716.api_surface = private, internal
```

You can configure this option for just this rule, for all rules, or for all rules in this category (Naming). For more information, see [Configure FxCop analyzers](configure-fxcop-analyzers.md).

### Analyzed symbol kinds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a small sentence about configurability of analyzed symbol kinds at the end of the Cause section.

@ktoliver
Copy link
Contributor

Hi @Evangelink - Could you make the revisions that @mavasani requests? Then we can merge the PR. Thanks.

@PRMerger15
Copy link
Contributor

@Evangelink : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Co-Authored-By: Manish Vasani <mavasani@microsoft.com>
@PRMerger17
Copy link
Contributor

@Evangelink : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Collaborator

@Mikejo5000 Mikejo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified request changes. Thanks!

@Mikejo5000
Copy link
Collaborator

#sign-off

@PRMerger20
Copy link
Contributor

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS Jak-MS merged commit c29d14b into MicrosoftDocs:master Apr 17, 2020
@Evangelink Evangelink deleted the CA1716-symbol-kind branch April 17, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1716 - Add a new configurability section
9 participants