-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boilerplate info about how to get support and provide feedback. #680
Conversation
…e to reference that article; turn off the feedback feature for the doc set.
1. Removed bold formatting on table heading, which interferes with the OPS heading style (the OPS style is a darker black that is different from the bold black). 2. Updated VBA-Docs (from lowercase "docs") to reflect actual repo name 3. Removed en-us from links so they go to localized pages (if any) 4. Added breaks where necessary to improve readability
OPS Build status updates of commit a974700: 🕙 Preparing: average preparing time is 3 min(s) 15 sec(s) |
OPS Build status updates of commit a974700: 🕙 Full build: average full build time is not available, there is no data for this repository.
|
@Linda-Editor here's the PR that adds the new boilerplate support/feedback content at the bottom of every file (and disables the OPS "feedback" feature). I've requested your review so that you can spot-check these changes. To do so, I'd suggest you take a look at the changes in several of the commits that this PR contains (for example: fed1c6e). The only type of change that you should see in each file is adding the Please do not merge this PR to master until you hear from me later today. I'm waiting for the OPS build to finish so that I can verify that everything looks okay on the staging site. |
@kbrandl Thanks, Kim, but where did you want me to check it? I can't access staging with my current perms (for 6 months I'm off corp-net). So the only place I can see these is in the GitHub UI, I think. Or I suppose I can clone GitHub and view your branch that way (in Visual Studio Code). Would that work? |
@kbrandl I looked at the GitHub change file that you linked to above, and everything looks good on that. |
@Linda-Editor you should use the GitHub UI to spot check the changes.
Check several commits, and if you see any types of changes other than the new |
@kbrandl Okay, will do. |
@kbrandl I randomly selected about 10 sets and scanned them, and all look good... |
@Linda-Editor thank you for reviewing -- can you please mark this PR as "Approved"? I will merge it to master after I'm able to verify changes on the staging site later today (build has been running for 2+ hours). BTW -- I see that Linda Lu has merged other PRs to master within the last hour. Can you please tell her to stop working in this repo (and to not 'publish to live' today)? Thanks. |
@kbrandl I let Linda Lu know as soon as I saw that she did that, and she reverted the one PR she merged. |
OPS Build status updates of commit a974700: ❌ Validation status: errors
api/TOC.md
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
This reverts commit a974700.
OPS Build status updates of commit 4437511: 🕙 Preparing: average preparing time is 3 min(s) 15 sec(s) |
OPS Build status updates of commit 4437511: 🕙 Full build: average full build time is not available, there is no data for this repository.
|
OPS Build status updates of commit 4437511: 🕙 Preparing: average preparing time is 3 min(s) 15 sec(s) |
OPS Build status updates of commit 4437511: 🕙 Full build: average full build time is 292 min(s) 3 sec(s) [calculated from last 1 build(s)]
|
Also, disable the OPS "feedback" feature.
Note: this PR adds boilerplate to all files except for files in the
/api
folder (a separate PR will update those files).