Update jest to ~21.2.1 #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved.
|
qz2017
reviewed
Jan 4, 2018
| @@ -29,6 +29,6 @@ | |||
| "@types/js-yaml": "3.9.1", | |||
| "@types/node": "6.0.88", | |||
| "gulp": "~3.9.1", | |||
| "@types/jest": "~20.0.4" | |||
| "@types/jest": "~21.1.8" | |||
There was a problem hiding this comment.
Did you test the case when one project fails to build? #Resolved
octogonz
reviewed
Jan 4, 2018
| @@ -11,7 +11,7 @@ | |||
| "devDependencies": { | |||
| "@types/chai": "3.4.34", | |||
| "chai": "~3.5.0", | |||
| "@types/jest": "~20.0.4", | |||
| "@types/jest": "~21.1.8", | |||
There was a problem hiding this comment.
"~21.1.8" [](start = 19, length = 9)
do you need the PNPM workaround in this PR? #Resolved
There was a problem hiding this comment.
The old version of gulp-core-build is apparently using the older jest. Once this is published, the next PR will upgrade the cyclic version of GCB that we are using to be the one we just published, which should make this go away In reply to: 355429219 [](ancestors = 355429219) Refers to: common/config/rush/npm-shrinkwrap.json:14 in 2b9abd6. [](commit_id = 2b9abd6, deletion_comment = False) |
|
Please do appropriate testing #Resolved |
This was referenced Jan 23, 2018
rikhoffbauer
pushed a commit
to rikhoffbauer/microsoft__api-documenter
that referenced
this pull request
Mar 23, 2020
* Update jest, jest-cli, and @types/jest * Rush Generate * Update for changes to Jest API * Changefiles * Add monkey patch for symlinks in jest-resolve * Refactor for readability
javier-garcia-meteologica
pushed a commit
to javier-garcia-meteologica/rushstack
that referenced
this pull request
Jun 26, 2020
* Update jest, jest-cli, and @types/jest * Rush Generate * Update for changes to Jest API * Changefiles * Add monkey patch for symlinks in jest-resolve * Refactor for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.