Skip to content

Support contributing different keybindings based on keyboard layout #1240

Open
@weinand

Description

@weinand

VSCode should ship out of the box with multiple keymaps (based on/optimized for each keyboard layout).
e.g. toggle line comment should be ctrl+7 on swiss keyboards, etc.

VSCode should detect at runtime the current system keyboard layout and employ different defaults, based on the keyboard layout.

Activity

added this to the Backlog milestone on Dec 14, 2015
added
bugIssue identified by VS Code Team member as probable bug
and removed
feature-requestRequest for new features or functionality
on Dec 14, 2015
modified the milestones: Dec 2015, Backlog on Dec 14, 2015
bpasero

bpasero commented on Dec 14, 2015

@bpasero
Member

Hm it should be...

assigned and unassigned on Dec 14, 2015
bpasero

bpasero commented on Dec 14, 2015

@bpasero
Member

So Cmd++ works for me, which is cool. However what is weird is that we set the keybinding like this:

{ primary: KeyMod.CtrlCmd | KeyCode.US_EQUAL }

I could not find KeyCode.US_PLUS.

@alexandrudima can you comment on this maybe?

weinand

weinand commented on Dec 14, 2015

@weinand
ContributorAuthor

@bpasero does Cmd++ work for you on a non-US keyboard?

bpasero

bpasero commented on Dec 14, 2015

@bpasero
Member

@weinand yes I am on german keyboard layout (ibm) and interestingly when I type "Cmd++" into the keyboard widget, I see it prints Cmd+= for me. What does it print for you?

weinand

weinand commented on Dec 14, 2015

@weinand
ContributorAuthor

@bpasero I'm on a Swiss German keyboard and I see "shift+cmd+=" and I know where the '=' comes from. On a US keyboard the '+' and the '=' are together on a key and since we only have KeyCode constants for the unshifted key, it is KeyCode.US_EQUAL.

@bpasero restating my question from above: did Cmd++ work for you without changing the keybinding?

71 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature-requestRequest for new features or functionalitykeyboard-layoutKeyboard layout issues

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Support contributing different keybindings based on keyboard layout · Issue #1240 · microsoft/vscode