Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad implementation #63

Closed
alexandregiordanelli opened this issue Dec 30, 2018 · 3 comments
Closed

Bad implementation #63

alexandregiordanelli opened this issue Dec 30, 2018 · 3 comments
Assignees
Labels
discussion enhancement New feature or request

Comments

@alexandregiordanelli
Copy link

alexandregiordanelli commented Dec 30, 2018

There is not filter when query on firestore. In this project, you are getting all documents of collection and filter on client side. It is a big problem, because firestore has filters like .where and firebase realtime not.

https://www.youtube.com/watch?v=mx1mMdHBi5Q

The engineer of firebase/google recommends this code:
https://jsbin.com/mosiza/edit?js,output

This solutions is scalable..

@MichaelSolati
Copy link
Owner

@alexandregiordanelli If you do have an issue with how the library performs I invite you to open a pull request with suggested changes, rather than just personal attacks towards me.

Now in regards to some points you mention:

  • Yes this is effectively a port of Geofire for Firestore, I've been pretty open with that.
  • You are able to perform where filters using the library as one of the arguments for your query object is a query function, so that's not really an issue. But I think you're referencing using where for the instead of startAt and endAt, which I think may be a good idea. I think it'll offer a similar performance, as its still a ranged query, however it'll open up the orderBy query modifiers for use by devs.

Point is I like your idea, but I do not appreciate the manner you expressed yourself and will ask that you try to be more courteous moving forward. Otherwise I will just close the issue and block you.

@MichaelSolati MichaelSolati self-assigned this Dec 30, 2018
@MichaelSolati MichaelSolati added enhancement New feature or request discussion labels Dec 30, 2018
@alexandregiordanelli
Copy link
Author

Sorry man! I didnt see the startAt and endAt filter.. I think you are right. I edited my issue and remove bad words.. Really sorry.. It is sad firestore doesnt have native geoqueries. thanks for share yor thoughts

@MichaelSolati
Copy link
Owner

Thank you for the apology @alexandregiordanelli , and I'm sorry if I came off a little strong. Anyway, I took your suggestion of using the where instead of my startAt and endAt. While I may not be able to do more with it now, I think it's the right solution for the library down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants