-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Tslint Errors #48
Comments
Can you share your package.json dependencies? |
Here's my dependencies. "dependencies": { |
Could you try updating your Typescript version to |
@MichaelSolati I have the same problem, tried to upgrade Typescript as well as tslint, both didn't resolve the issue. You can find an example repo here. Just run |
Thank you @subliminalvoice! Try running this version and see if it fixes it for you
I did test it, it seems to work on my end, but I just want to make sure it's good for you. A lot/some of it has to do with your linting rules. So I tried to make some fixes to accommodate more generic linting rules. There are/were two rules I needed to disable for that file, otherwise it should be good. And if it is I'll launch it as v2.2.3 |
@subliminalvoice & @zanecidan have either of you been able to test it out? |
@MichaelSolati haven't had the chance yet, I will try in 2(ish) hours. |
@MichaelSolati the linting works now, great! I tried to deploy the function and got:
but I guess that's due to some GCP internals, it will probably work with a proper version number (2.2.3) |
@subliminalvoice can I see the |
{ |
|
I used this library in my Firebase Function 1 month ago. It used to work until a recent npm install. I'm unable to trace which update cause the problem, but when I deploy these are the errors I get:
Module '@firebase/firestore-types' is not listed as dependency in package.json
'namespace' and 'module' are disallowed
Shadowed name: 'CollectionReference'
Shadowed name: 'DocumentChange'
Shadowed name: 'DocumentReference'
Shadowed name: 'DocumentSnapshot'
Shadowed name: 'GeoPoint'
Shadowed name: 'Query'
Shadowed name: 'QuerySnapshot'
Shadowed name: 'WriteBatch'
The text was updated successfully, but these errors were encountered: