Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add variable groups support #170

Conversation

ignatz42
Copy link
Contributor

@ignatz42 ignatz42 commented Jun 21, 2019

PR Summary

Added functions to Add, Get, Update, and Remove Variable groups.

PR Checklist

@ignatz42
Copy link
Contributor Author

Feature request: #24

@DarqueWarrior
Copy link
Collaborator

Reviewing now.

@DarqueWarrior DarqueWarrior self-assigned this Jun 22, 2019
@DarqueWarrior DarqueWarrior self-requested a review June 22, 2019 16:02
Copy link
Collaborator

@DarqueWarrior DarqueWarrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start. I added a lot of comments to the files.

I also noticed you have no unit tests for the additions. Please correct this.

.docs/Add-VSTeamVariableGroup.md Outdated Show resolved Hide resolved
.docs/Add-VSTeamVariableGroup.md Outdated Show resolved Hide resolved
.docs/Add-VSTeamVariableGroup.md Outdated Show resolved Hide resolved
.docs/Add-VSTeamVariableGroup.md Show resolved Hide resolved
Source/Classes/VSTeamVersions.ps1 Outdated Show resolved Hide resolved
.docs/Update-VSTeamVariableGroup.md Show resolved Hide resolved
.docs/Get-VSTeamVariableGroup.md Outdated Show resolved Hide resolved
.docs/Add-VSTeamVariableGroup.md Show resolved Hide resolved
.docs/Add-VSTeamVariableGroup.md Outdated Show resolved Hide resolved
integration/test/010_projects.Tests.ps1 Show resolved Hide resolved
@ignatz42
Copy link
Contributor Author

Thanks for the considered review! I think I've addressed the file comments. I need a bit of time to sort out the unit tests. I don't have TFS available to test against but I'll try to follow the existing tests.

Ignacio Galarza added 3 commits June 23, 2019 14:08
Updated integration tests
Fixed bug in Get-
Removed git format warnings
@ignatz42
Copy link
Contributor Author

I've added the unit tests along with the other requested changes. Will you please review the updates?

@DarqueWarrior
Copy link
Collaborator

DarqueWarrior commented Jun 25, 2019

Thanks for the considered review! I think I've addressed the file comments. I need a bit of time to sort out the unit tests. I don't have TFS available to test against but I'll try to follow the existing tests.

I really appreciate your support on the project.

I will send you a DM and give you access to my TFS 2017 and 2018 test machines. What is your twitter handle?

@DarqueWarrior
Copy link
Collaborator

TFS2017 supports variable groups with version 3.2-preview.1. I added to Set-VSTeamAPIVersion but I think the shape of the JSON might be different. I am willing to give you access to my 2017 and 2018. You can email me if you are not on twitter. I am dbrown at microsoft.

- Updated VSTS unit tests to use JSON sample
- Updated unit tests to stub 2017 functionality
- Set default VariableGroup version to TFS 2017
- Removed _supportsVariableGroups check
@ignatz42
Copy link
Contributor Author

ignatz42 commented Jun 28, 2019

I sent you an email earlier in the week but I suspect it was caught in a spam filter so I've just now sent another with the title "VSTeam PullRequest 170". Meanwhile, I've updated the unit tests to use JSON samples that I collected using Invoke-VSTeamRequest calls. If possible would you please add a similar sample from VSTS 2017? If so, I'll update the unit test to use the new file and then fix any failing code as necessary.

@ignatz42
Copy link
Contributor Author

ignatz42 commented Jul 1, 2019

Thanks for the access to the test system. I think I've addressed the TFS2017 differences with this last round of commits. I'll look forward to the next review.

@DarqueWarrior
Copy link
Collaborator

Thanks for the access to the test system. I think I've addressed the TFS2017 differences with this last round of commits. I'll look forward to the next review.

Did you run the integration tests? None of them pass for the variable groups. If you open 000_team.Tests.ps1 file it will tell you which environment variables to set to run the tests. I will email you a Azure DevOps organization you can use to run these tests. DO NOT RUN on your own accounts as they delete everything! Expect email soon.

- Fixed TFS2018 version
@ignatz42
Copy link
Contributor Author

ignatz42 commented Jul 2, 2019

Thanks for your email with instructions on performing the integration tests, much time was saved. The integration tests on all three target types complete successfully now.

@DarqueWarrior DarqueWarrior merged commit db80b54 into MethodsAndPractices:master Jul 2, 2019
@DarqueWarrior
Copy link
Collaborator

Well done! Your code is on it way to the PowerShell Gallery right now. Are you on Twitter? If so I can tag you in the announcement of the new version.

@ignatz42 ignatz42 deleted the feature/addVariableGroupsSupport branch July 2, 2019 23:01
@ignatz42
Copy link
Contributor Author

ignatz42 commented Jul 2, 2019

Thanks you very much! I'm not on Twitter but I am excited to put the changes to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants