feat: Allow usage of Text in Value props
#2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
approved these changes
Jan 8, 2025
FrederikBolding
approved these changes
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 497 497
Lines 10818 10826 +8
Branches 1652 1654 +2
=======================================
+ Hits 10247 10255 +8
Misses 571 571 ☔ View full report in Codecov by Sentry. |
Mrtenz
pushed a commit
that referenced
this pull request
Jan 8, 2025
7 tasks
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 14, 2025
## **Description** This PR allows the usage of the `Text` component in the Snap UI `Value` component props. [](https://codespaces.new/MetaMask/metamask-extension/pull/29624?quickstart=1) ## **Related issues** progresses: MetaMask/snaps#2984 ## **Manual testing steps** ```tsx <Box> <Row label="Amount"> <Value value={<Text color="success">1.555 ETH</Text>} extra={<Text color="error">2.44 $</Text>} /> </Row> </Box> ``` ## **Screenshots/Recordings**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 15, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/29624?quickstart=1){kind=link}
## **Description** This PR allows the usage of the `Text` component in the Snap UI `Value` component props. [](https://codespaces.new/MetaMask/metamask-extension/pull/29624?quickstart=1) ## **Related issues** progresses: MetaMask/snaps#2984 ## **Manual testing steps** ```tsx <Box> <Row label="Amount"> <Value value={<Text color="success">1.555 ETH</Text>} extra={<Text color="error">2.44 $</Text>} /> </Row> </Box> ``` ## **Screenshots/Recordings**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the usage of
Textin theValuecomponent propsvalueandextra.