Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): update @rhysd/actionlint to 1.7.1 #9790

Merged
merged 4 commits into from
Jun 3, 2024
Merged

chore(ci): update @rhysd/actionlint to 1.7.1 #9790

merged 4 commits into from
Jun 3, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 30, 2024 •
edited
Loading

Description

  • ci: Update actionlint to latest.
    • To unlock ubuntu-24.04. Also various fixes.
  • ci: Fix errors raised after actionlint update

https://github.com/rhysd/actionlint/releases

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added No QA Needed Apply this label when your PR does not need any QA effort. team-security No E2E Smoke Needed If the PR does not need E2E smoke test run labels May 30, 2024
@legobeat legobeat force-pushed the ci-bump-actionlint branch from ea062db to 1773f97 Compare May 30, 2024 01:22
@legobeat legobeat marked this pull request as ready for review May 30, 2024 01:23
@legobeat legobeat requested a review from a team as a code owner May 30, 2024 01:23
@legobeat legobeat mentioned this pull request May 30, 2024
Closed
7 tasks
@legobeat legobeat force-pushed the ci-bump-actionlint branch from 1773f97 to bab9eb9 Compare May 31, 2024 13:53
@legobeat legobeat force-pushed the ci-bump-actionlint branch from bab9eb9 to ab50104 Compare May 31, 2024 20:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

NicolasMassart
NicolasMassart approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@legobeat legobeat merged commit b9b3b58 into main Jun 3, 2024
31 checks passed
@legobeat legobeat deleted the ci-bump-actionlint branch June 3, 2024 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
@metamaskbot metamaskbot added the release-7.25.0 Issue or pull request that will be included in release 7.25.0 label Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.25.0 Issue or pull request that will be included in release 7.25.0 team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @NicolasMassart @metamaskbot