Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(000): remove # in pull request template as it will auto generate … #8000

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(000): remove # in pull request template as it will auto generate … #8000

merged 1 commit into from
Dec 4, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Dec 4, 2023 •
edited
Loading

Description

Small change to align with Extension repo: MetaMask/metamask-extension#22124

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin requested a review from a team as a code owner December 4, 2023 20:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin self-assigned this Dec 4, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d884f7a) 36.59% compared to head (e08ab38) 36.59%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8000   +/-   ##
=======================================
  Coverage   36.59%   36.59%           
=======================================
  Files        1120     1120           
  Lines       29188    29188           
  Branches     2717     2717           
=======================================
  Hits        10682    10682           
  Misses      17894    17894           
  Partials      612      612

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauthierpetetin gauthierpetetin merged commit 949d736 into main Dec 4, 2023
35 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/template branch December 4, 2023 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei approved these changes

Assignees

@gauthierpetetin gauthierpetetin

Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-mobile-platform Mobile Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauthierpetetin @codecov-commenter @wachunei @metamaskbot