Have mmi build being generated #19441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [cdd03dd]
Page Load Metrics (1604 ± 53 ms)
Bundle size diffs
|
This comment was marked as outdated.
This comment was marked as outdated.
Builds ready [26b36ab]
Page Load Metrics (1682 ± 77 ms)
Bundle size diffs
|
Builds ready [7f8bfa6]
Page Load Metrics (1833 ± 52 ms)
Bundle size diffs
|
brad-decker
approved these changes
Jun 6, 2023
Builds ready [2eca58c]
Page Load Metrics (1555 ± 37 ms)
Bundle size diffs
|
albertolive
approved these changes
Jun 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past the Lavamoat policy update script was changed to skip MMI build type, but now it can be updated to remove that and include it.
By running
yarn lavamoat:autowe can now see that the build is running successfully and the policy file is generated for MMI.Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.