Update TypeScript to v4.4 #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Gudahtt
force-pushed
the
update-typescript-4.4
branch
2 times, most recently
from
a540035 to
5e7c753
Compare
See the release announcement for more details about v4.4: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4-rc/ The main breaking change that affected us was the change in the default type of the `catch` error parameter from `any` to `unknown`. This was resolved in some places by changing the expected type to `unknown`. In cases where we need it to be an `Error` or where we use an `Error` property, the type is now checked at runtime. A minor change was needed in `BaseControlelrV2` as well, because TypeScript wasn't happy with the fact that it was never initialized for some reason, even though it wasn't supposed to be initialized (it was set to `never`). But initializing it as `undefined` serves the exact same purpose and resolved the error.
Gudahtt
force-pushed
the
update-typescript-4.4
branch
from
5e7c753 to
25bd13f
Compare
mcmire
previously approved these changes
Apr 22, 2022
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
mcmire
approved these changes
Apr 22, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
See the release announcement for more details about v4.4: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4-rc/ The main breaking change that affected us was the change in the default type of the `catch` error parameter from `any` to `unknown`. This was resolved in some places by changing the expected type to `unknown`. In cases where we need it to be an `Error` or where we use an `Error` property, the type is now checked at runtime. A minor change was needed in `BaseControllerV2` as well, because TypeScript wasn't happy with the fact that it was never initialized for some reason, even though it wasn't supposed to be initialized (it was set to `never`). But initializing it as `undefined` serves the exact same purpose and resolved the error.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
See the release announcement for more details about v4.4: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4-rc/ The main breaking change that affected us was the change in the default type of the `catch` error parameter from `any` to `unknown`. This was resolved in some places by changing the expected type to `unknown`. In cases where we need it to be an `Error` or where we use an `Error` property, the type is now checked at runtime. A minor change was needed in `BaseControllerV2` as well, because TypeScript wasn't happy with the fact that it was never initialized for some reason, even though it wasn't supposed to be initialized (it was set to `never`). But initializing it as `undefined` serves the exact same purpose and resolved the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the release announcement for more details about v4.4: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4-rc/
The main breaking change that affected us was the change in the default type of the
catcherror parameter fromanytounknown. This was resolved in some places by changing the expected type tounknown. In cases where we need it to be anErroror where we use anErrorproperty, the type is now checked at runtime.A minor change was needed in
BaseControlelrV2as well, because TypeScript wasn't happy with the fact that it was never initialized for some reason, even though it wasn't supposed to be initialized (it was set tonever). But initializing it asundefinedserves the exact same purpose and resolved the error.