Call sinon.restore() after each test using sinon
#789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
restore-sinon-mocks-after-each-test
branch
2 times, most recently
from
5042b13 to
6376cd0
Compare
|
|
`sinon.restore()` is now called after each test in any test suite that uses `sinon` for anything. This is recommended by the Sinon docs in their general setup instructions to avoid memory leaks.
Gudahtt
force-pushed
the
restore-sinon-mocks-after-each-test
branch
from
6376cd0 to
404a4af
Compare
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
`sinon.restore()` is now called after each test in any test suite that uses `sinon` for anything. This is recommended by the Sinon docs in their general setup instructions to avoid memory leaks.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
`sinon.restore()` is now called after each test in any test suite that uses `sinon` for anything. This is recommended by the Sinon docs in their general setup instructions to avoid memory leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinon.restore()is now called after each test in any test suite that usessinonfor anything. This is recommended by the Sinon docs in their general setup instructions to avoid memory leaks.