Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call sinon.restore() after each test using sinon #789

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 20, 2022

sinon.restore() is now called after each test in any test suite that uses sinon for anything. This is recommended by the Sinon docs in their general setup instructions to avoid memory leaks.

@Gudahtt Gudahtt force-pushed the restore-sinon-mocks-after-each-test branch 2 times, most recently from 5042b13 to 6376cd0 Compare April 20, 2022 20:47
@Gudahtt
Copy link
Member Author

Gudahtt commented Apr 20, 2022

This depends upon #788

Base automatically changed from remove-sinon-sandboxes to main April 21, 2022 22:33
`sinon.restore()` is now called after each test in any test suite that
uses `sinon` for anything. This is recommended by the Sinon docs in
their general setup instructions to avoid memory leaks.
@Gudahtt Gudahtt force-pushed the restore-sinon-mocks-after-each-test branch from 6376cd0 to 404a4af Compare April 21, 2022 22:49
@Gudahtt Gudahtt marked this pull request as ready for review April 21, 2022 22:49
@Gudahtt Gudahtt requested a review from a team as a code owner April 21, 2022 22:49
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gudahtt Gudahtt merged commit a8d4a87 into main Apr 22, 2022
@Gudahtt Gudahtt deleted the restore-sinon-mocks-after-each-test branch April 22, 2022 17:44
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
`sinon.restore()` is now called after each test in any test suite that
uses `sinon` for anything. This is recommended by the Sinon docs in
their general setup instructions to avoid memory leaks.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
`sinon.restore()` is now called after each test in any test suite that
uses `sinon` for anything. This is recommended by the Sinon docs in
their general setup instructions to avoid memory leaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants