Remove sinon sandboxes #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinon uses the "default sandbox" by default, and this is sufficient for everything we are using Sinon for. People tend to use the `createSandbox` method because they misunderstand how sandboxes work. This often results in interwoven use of a module-specific sandbox and the default sandbox, which leads to errors. Instead we should use the default sandbox and restore it after each test.
mcmire
approved these changes
Apr 21, 2022
|
Agreed! Just trying to get Sinon to behave more like Jest will before we switch them. |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sinon uses the "default sandbox" by default, and this is sufficient for everything we are using Sinon for. People tend to use the `createSandbox` method because they misunderstand how sandboxes work. This often results in interwoven use of a module-specific sandbox and the default sandbox, which leads to errors. Instead we should use the default sandbox and restore it after each test.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sinon uses the "default sandbox" by default, and this is sufficient for everything we are using Sinon for. People tend to use the `createSandbox` method because they misunderstand how sandboxes work. This often results in interwoven use of a module-specific sandbox and the default sandbox, which leads to errors. Instead we should use the default sandbox and restore it after each test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinon uses the "default sandbox" by default, and this is sufficient for everything we are using Sinon for. People tend to use the
createSandboxmethod because they misunderstand how sandboxes work. This often results in interwoven use of a module-specific sandbox and the default sandbox, which leads to errors.Instead we should use the default sandbox and restore it after each test.