Remove unused retry parameter from safelyExecute
#787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `retry` parameter of `safelyExecute` was unused, so it has been removed. Generally this parameter does not seem useful, and we are trying to remove all uses of this function anyway. This makes updating to TypeScript v4.4 slightly easier, because the invocation of the retry function is a type error on that version (because `error` is `unknown`).
mcmire
approved these changes
Apr 20, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `retry` parameter of `safelyExecute` was unused, so it has been removed. Generally this parameter does not seem useful, and we are trying to remove all uses of this function anyway. This makes updating to TypeScript v4.4 slightly easier, because the invocation of the retry function is a type error on that version (because `error` is `unknown`).
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `retry` parameter of `safelyExecute` was unused, so it has been removed. Generally this parameter does not seem useful, and we are trying to remove all uses of this function anyway. This makes updating to TypeScript v4.4 slightly easier, because the invocation of the retry function is a type error on that version (because `error` is `unknown`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
retryparameter ofsafelyExecutewas unused, so it has been removed. Generally this parameter does not seem useful, and we are trying to remove all uses of this function anyway.This makes updating to TypeScript v4.4 slightly easier, because the invocation of the retry function is a type error on that version (because
errorisunknown).